New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI download looks for resources in all user groups (fix #12146). #2383
Conversation
The addition of omero.group = -1 into the method call context forces the query to execute across all groups where the user is a member.
This also handles downloading of images and file annotations. The changes preserve the omero.client.uuid string in the context.
Works great. @bpindelski : my proposed refactoring to |
@joshmoore Thanks. You beat me to it - I was just about to push almost the same-looking code. Will cherry-pick. |
Added helper method for any omero.client user. Eventually, kwargs could be present for all of the uses ("omero.user", "omero.uuid", etc.)
Won't have time to make an extensive review of it but 👍 from my side by looking at it. |
Doh, sorry. Had it built locally for testing and figured might as well. |
Would this benefit from waiting on @sbesson's review? |
With @sbesson away, let's let him open a PR if he'd like to refactor your tests! 😄 I think with our 4 (6) eyes having been on it, we should be good to go. Merging. If anyone of the PY gateway contributors want to propose expanding the scope of the |
CLI download looks for resources in all user groups (fix #12146).
--rebased-to #2398 |
This PR updates the logic used by
bin\omero download
. Now all groups in which the logged in user is present are used when looking for an Image / OriginalFile / FileAnnotation ID. To test, follow scenario from http://trac.openmicroscopy.org.uk/ome/ticket/12146. Try out downloading an Image, FileAnnotation and OriginalFile.\cc @joshmoore, @sbesson: I'd appreciate feedback with regards to code and test structure - happy to correct if there is too much copypasta.