OmeroPy: Fix path handling and renaming for Python 2.7 on Windows #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is broken with Python 2.7 on Windows.
Merge the changes from jaraco/path@bee13d0
This reverts commit 2ee95fa.
ghost
mentioned this pull request
|
Tested server startup - all works OK. |
joshmoore
added a commit
that referenced
this pull request
Apr 29, 2014
OmeroPy: Fix path handling and renaming for Python 2.7 on Windows
|
Ah, I hadn't yet confirmed that DropBox was okay. I'll check later and flag up if there are any issues, though I don't expect there to be. |
|
Sorry about that, Colin. Missed the fact that this was the PR you took this morning. |
|
Aha - added a comment on http://trac.openmicroscopy.org.uk/ome/ticket/12203#comment:4. So do we want to test this during 5.0.2 pre-release ? Probably yes. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update path.py to work with Python 2.7 on Windows, and also fix the ConfigXML rewriting which was also broken and prevented running the cli.
Testing: Should make bin/omero work with Python 2.7 / Ice 3.5 on Windows. And there should be no regressions on any existing supported platform: ensure all python code such as dropbox is still functional.
--rebased-from #2356