Close ImportProcessPrx instances (Fix #12233) #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once upload is completed, the import process instance should be closed. The `HandlePrx` which is returned will continue functioning.
|
All looks fine here. Tested on gretzky CLI. No exceptions thrown and I can switch groups after import. Looks OK to merge (unless @jburel has comments). |
|
@joshmoore: I log the error instead of printing the error |
|
Changes look good now. |
jburel
added a commit
that referenced
this pull request
May 1, 2014
Close ImportProcessPrx instances (Fix #12233)
|
--rebased-to #2413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upload is completed, the import process instance should
be closed. The
HandlePrxwhich is returned will continuefunctioning.
For testing:
touch a.fakebin/omero import a.fakebin/omero sessions group SOMEOTHERGROUP# Previously this would fail/cc @jburel - better suggestion on logging inside of OMEROGateway?