Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permission downgrade message #2501

Merged
merged 1 commit into from
May 19, 2014

Conversation

dominikl
Copy link
Member

Updated the warning message shown when a group is going to be downgraded to Read-Only; to match OMERO.web, see PR #2485
Showing an error dialog if downgrade really fails, has to be tackled with another PR for 5.0.3 as it is a bigger change.

@jburel jburel added the dev_5_0 label May 14, 2014
@jburel
Copy link
Member

jburel commented May 15, 2014

@dominikl: links could have been created under Read-write too.

@dominikl
Copy link
Member Author

@jburel
Do you mean Read-Only? Change message to "Changing group to Private may fail if links have been created under Read-Write/Read-Only permissions"? But then it will differ from the according message in OMERO.web.

@jburel
Copy link
Member

jburel commented May 16, 2014

Read-annotate and read-write.
We do not expose read-write in the clients but we will need to review it.
Keep it in synch w/ Web for the time being

@sbesson
Copy link
Member

sbesson commented May 16, 2014

@dominikl/@jburel: are we expecting another commit on this PR before 5.0.2-rc1 ?

@dominikl
Copy link
Member Author

@sbesson
No, no more commit to come for this PR, just spoken to @jburel about that.
Can be merged as is.

@ximenesuk
Copy link
Contributor

Not listing for further review. @sbesson @jburel is this good to be merged?

@jburel
Copy link
Member

jburel commented May 19, 2014

Merging now.

jburel added a commit that referenced this pull request May 19, 2014
@jburel jburel merged commit 218a6c2 into ome:dev_5_0 May 19, 2014
@dominikl dominikl deleted the group_security_violation_2 branch May 19, 2014 10:49
@dominikl
Copy link
Member Author

--rebased-to #2526

@mtbc
Copy link
Member

mtbc commented Jun 16, 2014

Is the error dialog mentioned in the description ticketed somewhere (or even now done)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants