Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save line #2616

Merged
merged 1 commit into from
Jun 13, 2014
Merged

Save line #2616

merged 1 commit into from
Jun 13, 2014

Conversation

jburel
Copy link
Member

@jburel jburel commented Jun 12, 2014

Problem found while debugging the delete ROI error:

To test the PR:

  • Draw a line and Save
  • Turn the line into a Polyline and Save. No error message displayed.
  • Propagate the shape and Save
  • Go to one plane, remove the shape. Go to another plane and delete the shape. Save
  • Check that the roi is correctly saved.

@gusferguson
Copy link

@jburel
Tested using OMERO.insight-5.0.2-132-41d6e23-ice35-b27-mac octopus user-3 read-annotate-1

Draw a line and Save
Turn the line into a Polyline and Save
- no error message displayed.
Propagate the shape and Save
Go to one plane, remove the shape. Go to another plane and delete the shape. Save
- deleted in ROI manager pane - right click and using keyboard delete
- deleted via right click in viewer window
- deleted via ROI assistant
Check that the roi is correctly saved.

No error messages and all saved fine.

Behaves as expected.
Good to merge

joshmoore added a commit that referenced this pull request Jun 13, 2014
@joshmoore joshmoore merged commit 31b7c3c into ome:dev_5_0 Jun 13, 2014
@jburel
Copy link
Member Author

jburel commented Jun 13, 2014

--rebased-to #2626

@jburel jburel deleted the save-line branch October 2, 2014 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants