Fix TableBuilder for non ASCII characters #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OME-DCO-1.1-Signed-off-by: Sebastien Besson <seb.besson@gmail.com> (github: sbesson)
OME-DCO-1.1-Signed-off-by: Sebastien Besson <seb.besson@gmail.com> (github: sbesson)
OME-DCO-1.1-Signed-off-by: Sebastien Besson <seb.besson@gmail.com> (github: sbesson)
OME-DCO-1.1-Signed-off-by: Sebastien Besson <seb.besson@gmail.com> (github: sbesson)
|
Tests looked good. Also tried adding a unicode user and testing locally. @pwalczysko, when it comes time to come up with some "reference" database for all our testing and docker images and search indexing etc. etc, let's make sure there are lots of really nice čeština words, yeah? 😄 👍 |
joshmoore
added a commit
that referenced
this pull request
Jun 18, 2014
Fix TableBuilder for non ASCII characters
|
--rebased-to #2654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes http://trac.openmicroscopy.org/ome/ticket/12370
This PR refactors
TableBuilderandSQLStyleto handle non-ASCII characters. To test this PR,1- make sure the unit tests are passing (incl. the ones with non-ASCII characters). Any additional tests suggested?
2- from a merge server, create some users with non-ASCII characters in various locations (login, first/last name) and make sure
bin/omero user listreturns a table with columns correctly aligned. Optionally, test the same thing for group names andbin/omero group list.