Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12373 grid config #2652

Merged
merged 5 commits into from
Jun 24, 2014
Merged

12373 grid config #2652

merged 5 commits into from
Jun 24, 2014

Conversation

joshmoore
Copy link
Member

I recently asked @kennethgillen to take a glance at the properties in etc/omero.properties for readability etc. This PR is probably as good a place as any for suggestions for improvement. This may also go along with the recent discussion under ome/omero-documentation#826

@manics
Copy link
Member

manics commented Jun 19, 2014

👍 to not manually copying (ome/omero-documentation#826 (comment))

However, is there any real value in automatically copying things, as opposed to just linking directly to the source properties files/lines? E.g. Using Apache as an example, httpd.conf contains a brief explanation of each option, the online docs are much more thorough and provide more background info http://httpd.apache.org/docs/2.2/configuring.html

Or do the opposite- extensive documentation within the config files, and just highlight the most important ones in Sphinx.

@@ -4,7 +4,7 @@
#
# This properties file is compiled into blitz.jar and serves as a default
# for all values server-side values (client configuration happens differently).
# Any of these properties can be altered by using bin/omero config. This filel
# Any of these properties can be altered by using bin/omero config. This file
# can and should not be modified. Instead, new properties are set in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can and should not be modified. ???

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds rather like "must" doesn't it (-:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ae4bae5 clearer? 😄

@manics
Copy link
Member

manics commented Jun 19, 2014

Are you planning to remove all trac links? Some work, some redirect to the docs home page e.g. http://trac.openmicroscopy.org.uk/ome/wiki/OmeroSearch

@joshmoore
Copy link
Member Author

re: trac links -- will do, @manics, ta.

@sbesson
Copy link
Member

sbesson commented Jun 20, 2014

Seconding @manics on his comment. My personal preference would be to have extensive documentation in the ome-documentation repository and minimal documentation with hyperlinks in the config file itself. Auto-generation is pretty limited in this case in my opinion as we will need to manually edit the content to be auto-generated anyways (as opposed to e.g. metadata format pages in Bio-Formats).

If we are going that route, in terms of design, I think we should match the organization of the omero.properties with the sysadmin documentation is organized, i.e.

  • either have a global properties page with a glossary of all properties
  • or split by sections (as we semi-do now) where the properties are described and have sections of omero.properties matching sections of the documentation. This is my preference as well.

@joshmoore
Copy link
Member Author

I replaced the other trac URLs & pushed. I'd say we should probably end this here and wait for the auto-memory (gh-2595) and event-log-queue (gh-2639) PRs to go through, otherwise there will be endless conflicts.

@@ -296,7 +298,7 @@ omero.cluster.read_only=false
# the registry and other services will wait
# on remote services to respond.
#
# http://trac.openmicroscopy.org.uk/ome/wiki/OmeroGrid
# http://www.openmicroscopy.org/site/support/omero5/sysadmins/grid.html?highlight=grid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?highlight=grid?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always like the highlighting, and it shows what to search for in our side box. But happy to remove those.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think highlighting works when a term is mentioned rarely in a page, but in this case the whole page is relevant.

@manics
Copy link
Member

manics commented Jun 24, 2014

http://quartz.sourceforge.net appears to be dead

@joshmoore
Copy link
Member Author

Pushed.

@manics
Copy link
Member

manics commented Jun 24, 2014

👍

@sbesson
Copy link
Member

sbesson commented Jun 24, 2014

@joshmoore: any additional change planned?

@joshmoore
Copy link
Member Author

Nope. Bigger changes need to wait for my other 2 PRs to be merged or excluded.

sbesson added a commit that referenced this pull request Jun 24, 2014
@sbesson sbesson merged commit cd8ff5e into ome:dev_5_0 Jun 24, 2014
@joshmoore
Copy link
Member Author

--rebased-to #2680

@joshmoore joshmoore mentioned this pull request Jul 14, 2014
5 tasks
@joshmoore joshmoore deleted the 12373-grid-config branch July 14, 2014 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants