-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12373 grid config #2652
12373 grid config #2652
Conversation
👍 to not manually copying (ome/omero-documentation#826 (comment)) However, is there any real value in automatically copying things, as opposed to just linking directly to the source properties files/lines? E.g. Using Apache as an example, Or do the opposite- extensive documentation within the config files, and just highlight the most important ones in Sphinx. |
@@ -4,7 +4,7 @@ | |||
# | |||
# This properties file is compiled into blitz.jar and serves as a default | |||
# for all values server-side values (client configuration happens differently). | |||
# Any of these properties can be altered by using bin/omero config. This filel | |||
# Any of these properties can be altered by using bin/omero config. This file | |||
# can and should not be modified. Instead, new properties are set in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can and should not be modified.
???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds rather like "must" doesn't it (-:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ae4bae5 clearer? 😄
Are you planning to remove all trac links? Some work, some redirect to the docs home page e.g. http://trac.openmicroscopy.org.uk/ome/wiki/OmeroSearch |
re: trac links -- will do, @manics, ta. |
Seconding @manics on his comment. My personal preference would be to have extensive documentation in the ome-documentation repository and minimal documentation with hyperlinks in the config file itself. Auto-generation is pretty limited in this case in my opinion as we will need to manually edit the content to be auto-generated anyways (as opposed to e.g. metadata format pages in Bio-Formats). If we are going that route, in terms of design, I think we should match the organization of the
|
@@ -296,7 +298,7 @@ omero.cluster.read_only=false | |||
# the registry and other services will wait | |||
# on remote services to respond. | |||
# | |||
# http://trac.openmicroscopy.org.uk/ome/wiki/OmeroGrid | |||
# http://www.openmicroscopy.org/site/support/omero5/sysadmins/grid.html?highlight=grid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ?highlight=grid
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always like the highlighting, and it shows what to search for in our side box. But happy to remove those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think highlighting works when a term is mentioned rarely in a page, but in this case the whole page is relevant.
http://quartz.sourceforge.net appears to be dead |
Pushed. |
👍 |
@joshmoore: any additional change planned? |
Nope. Bigger changes need to wait for my other 2 PRs to be merged or excluded. |
--rebased-to #2680 |
I recently asked @kennethgillen to take a glance at the properties in
etc/omero.properties
for readability etc. This PR is probably as good a place as any for suggestions for improvement. This may also go along with the recent discussion under ome/omero-documentation#826