Lucene Query Builder Unification #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than have 2 implementations of the query parsing logic, omero.gateway now uses the byLuceneQueryBuilder method to have the custom query built server-side.
Now the date query of byLuceneQueryBuilder can be based on either the import date or the acquisitionDate by setting the new parameter.
SearchControl was not properly making use of the HqlControl _configure method. With this commit, all of the options from HqlControl are also provided for regular search, including output style and `--all` for querying across groups.
Some searches like '%' generated empty strings in LQB which led to invalid query exceptions "<EOF>" etc.
|
Conflicting PR. Removed from build OME-5.0-merge-push#110. See the console output for more details. |
|
This all seems to be behaving as expected.
None of these are blockers (or even related to this PR?) so: good to merge. |
|
Thanks, @will-moore. |
joshmoore
added a commit
that referenced
this pull request
Jul 16, 2014
Lucene Query Builder Unification
|
@will-moore Sounds reasonable; I'm going to make your proposed changes for Insight in another PR. |
|
--rebased-to #2858 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the migration of @dominikl's
byLuceneQueryBuilder()method to the server in gh-2676 all other clients (OMERO.web and the CLI) need to be updated to make use of the single implementation. Testing involves showing that results from any one of the clients match the other 2 clients. Search options which should be involved include:Testing user/group semantics via the CLI might be considered out-of-scope.
Follow-ons to this PR will include:
modify server-side implementation to better handle some queriesadded here with aa21d07Note: This PR replaces gh-2784