Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webtest fixes 9498 #308

Merged
merged 4 commits into from
Aug 30, 2012
Merged

Webtest fixes 9498 #308

merged 4 commits into from
Aug 30, 2012

Conversation

will-moore
Copy link
Member

Small improvements / fixes to the webtest Channel Overlay viewer and Image Dims viewer.

To test:

Go to the webtest homepage: /webtest/
Click the 5 main links and see if they are obviously broken (E.g. 404s, missing images).

@eehill
Copy link

eehill commented Aug 27, 2012

All looks to be working - no obvious big 404 errors.

Some observations follow (perhaps normal or to be considered as RFEs)?

  • dataset_split_view - on clicking update after deselecting something (the channel options then disappear, which I expect is supposed to happen but a remove/restore option might be good) and often you see a broken image link - this seems to depend on which random dataset is chosen (might be when the images in the datasets do not have the same channels in all images. If people use this a lot, it might be better to have preloaded good datasets?)
  • channel overlay viewer - it does not seem possible to apply alterations to the zoom level, which makes viewing difficult if the image is large

@jburel
Copy link
Member

jburel commented Aug 27, 2012

If RFE cannot be done in that PR, could you move them to https://docs.google.com/spreadsheet/ccc?key=0ArfUkRuStsCEdFVka1JPZ2s4RDJzQTAtN3M3bzhScVE#gid=0 ?

Webtest split-dataset form works independently (when not a plugin)
a6efeb8 
We include jquery.js etc in the dataset split-view html page itself, so that it can work
when not embedded in the webclient.
It means we load these unnecessarily when this IS a plugin, but this is a very small cost which
is accepable since this is mostly demo code and it's primary role is as an example
@will-moore
Copy link
Member Author

The commit above fixes the 'channel options disappear' issue. The broken images in some datasets is due to a known issue: http://trac.openmicroscopy.org.uk/ome/ticket/8888

I could add zooming to the channel overlay, but this is really an existing RFE and shouldn't block this PR.

Cheers.

@eehill
Copy link

eehill commented Aug 29, 2012

The channel options fix looks good now.

Re. the zooming on the channel overlay viewer. If it doesn't work, then should the zoom box option be removed completely?

@will-moore
Copy link
Member Author

Ah - the zoom box is for the "lens". Try dragging to draw a rectangle on the image. You should see a zoomed-in area beside the image. If you update the zoom level and draw again, you'll see a different zoom.

@eehill
Copy link

eehill commented Aug 29, 2012

& it all suddenly becomes clear. Got it. All looks good then.

joshmoore added a commit that referenced this pull request Aug 30, 2012
@joshmoore
Merge pull request #308 from will-moore/webtest_fixes_9498
2219c8d 
Webtest fixes 9498
@joshmoore joshmoore merged commit 2219c8d into ome:develop Aug 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev_4_4
Projects
None yet
Milestone
4.4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@will-moore @eehill @jburel @joshmoore