Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: Single wildcards and date ranges #3104

Merged
merged 2 commits into from Oct 13, 2014
Merged

Search: Single wildcards and date ranges #3104

merged 2 commits into from Oct 13, 2014

Conversation

dominikl
Copy link
Member

  • Prevent single wildcard searches (*): A error message is shown (before: Insight crashed with APIUsageException)
  • Prevent entering 'To' date which is prior to 'From' date and vice versa: Message is shown (before: Dates were just swapped).
    (also removed some unused code from the classes concerned)

@gusferguson
Copy link

@dominikl
Tested using OMERO.insight-5.1.0-m1-266-0b9e1d4-ice34-b298-mac trout user-3 read-only-1

Behaves as expected.
Goos to merge.

omero insight

omero insight

joshmoore added a commit that referenced this pull request Oct 13, 2014
@joshmoore
Merge pull request #3104 from dominikl/prevent_single_wildcard_search
18819e9 
Search: Single wildcards and date ranges
@joshmoore joshmoore merged commit 18819e9 into ome:develop Oct 13, 2014
@dominikl
Copy link
Member Author

--no-rebase

@sbesson sbesson modified the milestones: 5.1.0-m1, 5.1.0-m2 Oct 14, 2014
@dominikl dominikl deleted the prevent_single_wildcard_search branch January 6, 2015 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
develop
Projects
None yet
Milestone
5.1.0-m2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dominikl @gusferguson @joshmoore @sbesson