Re changes

[jburel]

This PR

• Prevent user from passing value outside min/max range for double and float
• Reset window interval is directly modified in DB

To test this PR

• Modify start/end in DB. Save values outside the pixel type range.

[ghost]

@jburel Which table in the DB has these settings?

[ghost]

I'll need to double-check with you what's supposed to happen here, but the behaviour seems quite wrong, for float/double images (fine for uint8/16). I've imported several float and double images. The min and max appear to be clamped to the global min/max for each channel. This means I can't normalise the rendering settings across multiple images with differing global min/max. Example: Red is max=0.745. I can set this to 0.8, 1.0 or 2.5, or even 40000 but this isn't reflected in the rendering. I think this is far too restrictive, and imposes unreasonable limitations upon what a user would reasonably expect to do. I set these values directly in the UI (they save correctly) and by updating channelbinding in the DB; no effect in either case.

[ghost]

I should also note that thumbnail generation for all pixel types is broken; not sure if this PR is specifically responsible, but it was working for all pixel types last time I checked a couple of weeks back.

[ghost]

Test data on trout, user-4 flt/data.

[jburel]

@rleigh-dundee: I was limiting to min/max. I have removed that limitation. To be retested on monday.

[pwalczysko]

Tested float and double images on trout merge user-4 Project fit.

Changed the inputend and inputstart values in the channelbinding table in the DB. This changed the values shown in Insight as expected.
Did changes in Insight as well, this showed up int the DB as expected.
Tried negative values and values higher than Max, both worked fine.
The rendering of the image changes as expected when these values are imposed.

Two minor issues:

1. I can set the inputend lower than the inputstart in the DB. I cannot do it in Insight, but when I try to do so, and press Save to All (Save is disabled as expected), the both sliders on the channel in question go to the right hand side (see screenshot)
2. When I set a value lower than Min or higher than Max, and then try to slide the sliders in Insight, they slide just between Min and Max again, although I just set the value manually. Is this what we want @jburel ?

[jburel]

@pwalczysko: sorry missed your comment

1. I will see how we can prevent that. We mainly prevent it in the UI
2. Second one look like a follow up problem that @dominikl was looking at. see https://trello.com/c/KwLoyXTn/87-rendering-follow-up

[jburel]

@pwalczysko: The last commit will swap the start/end value when doing a Save all.

[pwalczysko]

It works kind of fine.
But the last commit does not swap the values when doing a Save all. Instead, it changes the last edited value to the value before editing.

[pwalczysko]

I think this is acceptable behaviour though.

[jburel]

this is very much a corner case

[jburel]

@pwalczysko: okay to merge?

[pwalczysko]

Okay to merge

[jburel]

Thanks all. merging the PR, which is part of m2

[jburel]

--no-rebase