Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roi bugs #317

Merged
merged 5 commits into from
Aug 30, 2012
Merged

Roi bugs #317

merged 5 commits into from
Aug 30, 2012

Conversation

jburel
Copy link
Member

@jburel jburel commented Aug 27, 2012

chris-allan
chris-allan reviewed Aug 27, 2012
View reviewed changes
components/insight/SRC/org/openmicroscopy/shoola/agents/measurement/MeasurementAgent.java
@@ -189,6 +189,7 @@ private void handleSaveData(SaveData evt)
MeasurementViewer viewer = MeasurementViewerFactory.getViewer(null,
evt.getPixelsID());
if (viewer != null && evt.getType() == SaveData.MEASUREMENT_TYPE) {
System.err.println("Save");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we don't need this System.err.println()?

@jburel
Copy link
Member Author

jburel commented Aug 27, 2012

Thanks for point that out, this should not have been there. I have to do further tests following a discussion with Michael

@chris-allan
Copy link
Member

@jburel: Cool. Is it within scope to be dealing with any of the things with respect to OMERO.insight that we've already dealt with for OMERO.web in #313 on this PR? (theZ = null, parsing of OME-XML model points values, etc.)

@jburel
Copy link
Member Author

jburel commented Aug 27, 2012

I will discuss with Will tomorrow and keep you updated.

@jburel
Copy link
Member Author

jburel commented Aug 29, 2012

@rleigh-dundee: could you test #9486?

@ghost
Copy link

ghost commented Aug 29, 2012

This appears to work OK. For two out of the three ROIs I tested, two got an "Unable to delete the object" message, even though the deletion had actually succeeded. This is probably a separate issue.

@jburel
Copy link
Member Author

jburel commented Aug 29, 2012

@rleigh-dundee: delete is certainly related to the point raised by @joshmoore during stand-up

@jburel
Copy link
Member Author

jburel commented Aug 29, 2012

@joshmoore:
From Michael Porter (testing the Excel export issue)
it seems to be working just fine. Thanks for sorting this, it really was the only “easy” way to get data out.

PR ready to be merged

joshmoore added a commit that referenced this pull request Aug 30, 2012
@joshmoore
Merge pull request #317 from jburel/roi-bugs
ad0b6ac 
Roi bugs
@joshmoore joshmoore merged commit ad0b6ac into ome:develop Aug 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev_4_4
Projects
None yet
Milestone
4.4.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jburel @chris-allan @joshmoore