Bugfix for down scaling already very small images #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A definite improvement, already good to merge. I could trigger the bug by importing a 2×2 image, attached below for convenience, and zooming out from that, but that's even less of a real-world issue! Don't know if you want to bother addressing that now or not. |
|
Yes, I can do that within this PR. |
dominikl
force-pushed
the
magnification_fix_for_very_small_images
branch
2 times, most recently
from
f228ade
to
e1201e2
Compare
dominikl
force-pushed
the
magnification_fix_for_very_small_images
branch
from
e1201e2
to
5c1d99d
Compare
|
Image Viewer can now also handle images < 3px. |
|
👍 Happy to if nobody else grabs it. |
|
No problems at all now with zooming, can't get that error dialog to appear. Good to merge. |
joshmoore
added a commit
that referenced
this pull request
Nov 21, 2014
…ll_images Bugfix for down scaling already very small images
|
--no-rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is a "real world" issue, but fixes: https://trac.openmicroscopy.org.uk/ome/ticket/12638
Ensures that an image can't be down scaled to less than 3px.
Test: Open a very small image (3 or 4px) in full viewer, try to zoom out; nothing should happen if the image would get smaller than 3px (previously: error message was shown).