Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed potential NPE #3452

Merged
merged 1 commit into from Feb 9, 2015
Merged

Fixed potential NPE #3452

merged 1 commit into from Feb 9, 2015

Conversation

dominikl
Copy link
Member

@dominikl dominikl commented Feb 6, 2015

See Ticket 12547

I don't know how to test this; but a code review should be sufficient (it's just an additional check for null, and password is the only Object which could trigger a NullPointerException in this toString() method)

--no-rebase

@jburel jburel added the develop label Feb 6, 2015
@mtbc
Copy link
Member

mtbc commented Feb 6, 2015

Code change looks sensible. 👍 Don't know if you want to log anything if it is null?

@jburel
Copy link
Member

jburel commented Feb 9, 2015

I won't do anything. I need to find work I did for connection using only session id.
we might have a null password in that case.

@joshmoore
Copy link
Member

Guess the question is what it means for the password to be null. If no one knows, logging at warn might make sense.

@jburel
Copy link
Member

jburel commented Feb 9, 2015

There is no ref to logger at that level, a ref will have to be specified or it will have to be registered when the class is initialized.

@joshmoore
Copy link
Member

Fair enough. Unless there's a precedent of adding "# TODO on refactoring", I'd say let's merge and move on.

@mtbc
Copy link
Member

mtbc commented Feb 9, 2015

Fine with me.

joshmoore added a commit that referenced this pull request Feb 9, 2015
@joshmoore joshmoore merged commit 8807757 into ome:develop Feb 9, 2015
@sbesson sbesson added this to the 5.1.0-m4 milestone Feb 17, 2015
@dominikl dominikl deleted the trac_12547 branch February 18, 2015 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants