Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12513: close import log earlier to set its size correctly #3458

Merged
merged 1 commit into from Feb 9, 2015

Conversation

mtbc
Copy link
Member

@mtbc mtbc commented Feb 6, 2015

Do some imports, look in the server's managed repository, and check that the import log file sizes on disk match those for the import logs in the database. Fixes http://trac.openmicroscopy.org.uk/ome/ticket/12513.

bin/omero hql "SELECT path||name, size FROM OriginalFile WHERE mimetype = 'application/omero-log-file'"

We do thus close the import log very slightly earlier, but it is still after the interesting stuff has all happened, and after one has destroyed the session it is rather harder to update the database.

--no-rebase

@jburel jburel added the develop label Feb 6, 2015
@joshmoore
Copy link
Member

e.g.

2015-02-09 11:05:04,480 8000       [l.Client-1] INFO   ormats.importer.cli.LoggingImportMonitor - METADATA_PROCESSED Step: 4 of 5  Logfile: 74695
2015-02-09 11:05:04,505 8025       [l.Client-0] INFO   ormats.importer.cli.LoggingImportMonitor - OBJECTS_RETURNED Step: 5 of 5  Logfile: 74695
2015-02-09 11:05:04,678 8198       [l.Client-1] INFO   ormats.importer.cli.LoggingImportMonitor - IMPORT_DONE Imported file: /lifesci/groups/jrs/jamoore/pr3458.fake
Imported pixels:
40078
Other imported objects:
Fileset:17914
Image:42278
2015-02-09 11:05:04,678 8198       [l.Client-1] INFO      ome.formats.importer.cli.ErrorHandler - Number of errors: 0

==> Summary
1 file uploaded, 1 fileset created, 1 image imported, 0 errors in 0:00:01.516
[jamoore@ome-c6100-3 ~]$ /opt/hudson/workspace/OMERO-5.1-merge-build/src/dist/bin/omero download 74695  pr3458.74695
[jamoore@ome-c6100-3 ~]$ ls -ltra pr3458.74695
-rw-r--r-- 1 jamoore lsd 12973 Feb  9 11:05 pr3458.74695
[jamoore@ome-c6100-3 ~]$ ls -ltra /repositories/OMERO-5.1-merge-deploy/ManagedRepository/user-1_8/2015-02/09/11-05-03.296.log
-rw-rw-r-- 1 hudson hudson 12973 Feb  9 11:05 /repositories/OMERO-5.1-merge-deploy/ManagedRepository/user-1_8/2015-02/09/11-05-03.296.log

👍

joshmoore added a commit that referenced this pull request Feb 9, 2015
fix #12513: close import log earlier to set its size correctly
@joshmoore joshmoore merged commit 31f73a2 into ome:develop Feb 9, 2015
@mtbc mtbc deleted the fix-12513-import-log-size branch February 9, 2015 11:12
@joshmoore
Copy link
Member

Sorry, missing from the above is:

[jamoore@ome-c6100-3 ~]$ /opt/hudson/workspace/OMERO-5.1-merge-build/src/dist/bin/omero hql "select o.size from OriginalFile o where o.id = 74695" -q
 # | Col1  
---+-------
 0 | 12973 
(1 row)

@mtbc
Copy link
Member Author

mtbc commented Feb 9, 2015

Now we just have to figure out if/how to fix the old ones. 😃

@joshmoore
Copy link
Member

I'd assume this goes along with the automatic compression, etc.

@mtbc
Copy link
Member Author

mtbc commented Feb 9, 2015

Oh, yes, could well.

@sbesson sbesson added this to the 5.1.0-m4 milestone Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants