Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference handler for Annotation -> Annotation #351

Merged
merged 1 commit into from
Sep 14, 2012

Conversation

melissalinkert
Copy link
Member

See #9541.

@qidane
Copy link
Contributor

qidane commented Sep 12, 2012

Hi Melissa, I have been given this to test but have no idea how to. I did make the changes to the sample file #352 so it can be used for tagset testing.

@melissalinkert
Copy link
Member Author

@qidane You just need to verify that the file from PR #352 imports without error and has the tagset shown in Insight if you checkout the branch for this PR and have the branch from this other PR:

ome/bioformats#139

checked out in the bioformats submodule. Whichever server you're running against also needs to have this branch, though, so just be careful of that.

@qidane
Copy link
Contributor

qidane commented Sep 12, 2012

Thanks to help from Roger & Josh I got howe updated to be my test server. The file imports without error, but does not appear inside the dataset. (Probably an unrelated issue?)

If you find the image through the calendar it does have the tagset correctly linked. And the tagset is visible in the tag view and contains the two correct tags.

@melissalinkert
Copy link
Member Author

Orphaned OME-XML files are certainly a known issue (I reported it on the sprint 4 spreadsheet, and @sbesson reported it on the sprint 5 spreadsheet), and not related to this.

@qidane
Copy link
Contributor

qidane commented Sep 13, 2012

merge

joshmoore added a commit that referenced this pull request Sep 14, 2012
…lers

Add reference handler for Annotation -> Annotation
@joshmoore joshmoore merged commit 60914c7 into ome:develop Sep 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants