Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DnD move dataset #3588

Merged
merged 1 commit into from Mar 10, 2015
Merged

DnD move dataset #3588

merged 1 commit into from Mar 10, 2015

Conversation

jburel
Copy link
Member

@jburel jburel commented Mar 8, 2015

Allow to move dataset out of project via DnD.
see https://trac.openmicroscopy.org/ome/ticket/11083

To test:

  • Select a dataset in a Project
  • Move the dataset out of the project using DnD
  • The action should be performed w/o dialog popping up

@jburel jburel added the develop label Mar 8, 2015
@gusferguson
Copy link

@jburel

Tested using OMERO.insight-5.1.0-m5-281-55aa544-ice34-b432-win user-3 read-only-1
Confirmed with OMERO.insight-5.1.0-m5-281-55aa544-ice34-b432-mac_Java7+

Not working at all.
Get + icon when dragging but nothing happens on drop - no dialog opens, no movement of dataset occurs.
On Mac get red no icon when trying to drag and drop into orphaned or other dataset. Don't get this in Windows.

@jburel
Copy link
Member Author

jburel commented Mar 9, 2015

you cannot drop a dataset into another dataset.
The orphaned is another problem it should only be for images. On the ticket it was indicating dropping on user.
Does it work?

@gusferguson
Copy link

@jburel - no does not work dropping on user.

@jburel
Copy link
Member Author

jburel commented Mar 9, 2015

humm
You will have to show me, just tested with today's build on mac and I cannot reproduce issue.

@gusferguson
Copy link

@jburel - drag and drop works fine on Mac now but still not working on Windows in Parallels. Need to test on full windows machine.

@jburel
Copy link
Member Author

jburel commented Mar 10, 2015

@gusferguson: it is working on windows, but might not be as "natural" as we look like it to be.

@gusferguson
Copy link

@jburel - Drag and Drop works on Windows - Parallels and Stand-alone if shift key is held down while D&Ding. On Windows still not getting the + icon appearing as on Mac.

Agree should merge this PR and roll the Windows issue into a thorough review of state of Drag and Drop on Mac, Windows and Linux. Will also include any other bugs/RFEs outstanding related to D&D.

Good to merge.

joshmoore added a commit that referenced this pull request Mar 10, 2015
@joshmoore joshmoore merged commit 12528d2 into ome:develop Mar 10, 2015
@jburel
Copy link
Member Author

jburel commented Mar 11, 2015

--no-rebase

@jburel jburel deleted the dataset-dnd branch March 19, 2015 14:09
@sbesson sbesson added this to the 5.1.0-m5 milestone Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants