Disable delete action if a well field is selected #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested using OMERO.insight-5.1.0-160-e43dd1d-ice34-b464-mac_Java7+ user-3 read-only-1. Behaves as expected. |
|
Delete is still available from the Data manager menu i.e. Edit>Delete |
|
Forgot about the menu. Fixed with my last commit.
Select the Plate or Run and check that the delete action is then enabled again. |
|
Good to merge. |
joshmoore
added a commit
that referenced
this pull request
Apr 13, 2015
Disable delete action if a well field is selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ticket: https://trac.openmicroscopy.org/ome/ticket/12795
Test:
Select a well and make sure the "Delete" action is disabled, in the context menu as well as in the "Screens" toolbar. Check that the action is enabled otherwise, e. g. if the Run or the Plate is selected.
--no-rebase