Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse wheel Z-frame scrolling #3712

Merged
merged 1 commit into from Apr 15, 2015

Conversation

dominikl
Copy link
Member

Fixes Ticket 12829

Test: Open an image (not a big image) with multiple Z frames. Make sure the mouse wheel scrolling through the Z frames works.

@dominikl dominikl changed the title Prevent adding mouselisteners multiple times Mouse wheel Z-frame scrolling Apr 14, 2015
@mtbc
Copy link
Member

mtbc commented Apr 15, 2015

Good to merge.

joshmoore added a commit that referenced this pull request Apr 15, 2015
@joshmoore joshmoore merged commit 38c2b1e into ome:develop Apr 15, 2015
@will-moore
Copy link
Member

@dominikl Certainly the mouse-wheel scrolling works, but it sometimes also zooms the image. I'm not sure exactly what triggers this, but if I scroll up and down repeatedly, I usually end up at a higher zoom level. This happens most reliably at max Z when all scrolling results in zoom, but also can happen at anyt other Z-index too. Also, clicking and dragging of the image with the mouse still changes the z-index instead of panning, but maybe you meant to fix that in a different PR?

@mtbc
Copy link
Member

mtbc commented Apr 15, 2015

Gah, sorry I missed that misfeature.

@dominikl
Copy link
Member Author

@will-moore I can't reproduce the mixed scroll/zoom behaviour. There's a difference between small and big images. Small images: Scroll and drag change Z frame, no zoom; big images: scroll zooms in/out, drag moves the image around. I think that's intended.

@joshmoore joshmoore added this to the 5.1.1 milestone Apr 23, 2015
@dominikl dominikl deleted the mousewheel_z_scroll_fix branch May 25, 2015 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants