Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ij #3752

Merged
merged 2 commits into from
Apr 24, 2015
Merged

Import ij #3752

merged 2 commits into from
Apr 24, 2015

Conversation

jburel
Copy link
Member

@jburel jburel commented Apr 22, 2015

Fix possible NPE
see https://trac.openmicroscopy.org.uk/ome/ticket/12833

to test:

  • Connect to OMERO using the ij plugin
  • Open an image
  • Crop the image,
  • Select Save and Upload
  • Select a project and "new from folder"
  • Check that the cropped image is imported as ome.tiff

@jburel jburel added the develop label Apr 22, 2015
@gusferguson
Copy link

@jburel

Tested using OMERO.insight-ij-5.1.0-511-eee50ab-ice34-b483 and merge build bioformats package from today. Trout user-3.

Cropped images are saved back to OMERO as OME-TIFF as expected.
Good to merge.

It is interesting to note that this whole workflow gives a way to circumvent OMERO permissions by opening a read-only image belonging to another user and then saving it back to the server as your own image. Something to bear in mind down the track,

@joshmoore
Copy link
Member

Thanks, @gusferguson. Merging.

(At the risk of misusing this PR for a discussion, is the workflow not something a la deep copy? So I don't know if I would really consider it circumventing the permission system, but it does allow copying, just when data duplication.)

joshmoore added a commit that referenced this pull request Apr 24, 2015
@joshmoore joshmoore merged commit 3f36a44 into ome:develop Apr 24, 2015
@sbesson sbesson added this to the 5.1.1 milestone Apr 28, 2015
@jburel jburel deleted the import-ij branch June 11, 2015 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants