New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding login params for autologin #3810
Conversation
In general, big 👍 for this @aleksandra-tarkowska. The only caveat that might arise is the need for a static webstart page so that we can sign it: https://trello.com/c/4KjZpcX2/494-sign-webstart-jnlp-file |
@joshmoore There is nothing stopping anyone from replacing template by |
Makes sense! (Think the hope, though, is that we can provide a signed one, which is going to be tricky) |
SessionID is now included in the jnlp properties. Good to merge. |
Can I propose we leave open until we have the two working together in case there is some back and forth? |
corresponding insight PR gh-3820 |
|
Assuming that all testing for this PR was commented under #3820, merging. |
adding login params for autologin
This PR should allow passing login parameters to auto login into Insight.
JNLP file now gets host port and session ID that is minimum to log in
Note: Webstat page is also available when user is not logged in. In this case there will be default server host and port set and no sessionid provided. These parameters should be used as a helper to choose the right server from the list.
cc: @jburel @dominikl