Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding login params for autologin #3810

Merged
merged 8 commits into from May 25, 2015
Merged

adding login params for autologin #3810

merged 8 commits into from May 25, 2015

Conversation

atarkowska
Copy link
Member

This PR should allow passing login parameters to auto login into Insight.

JNLP file now gets host port and session ID that is minimum to log in

<property name="jnlp.omero.host" value="trout...org"/>
<property name="jnlp.omero.port" value="4064"/>
<property name="jnlp.omero.sessionid" value="79e4596a-bb8c-470f-8e6a-47b91ed0c5ab"/>
<property name="jnlp.omero.web.host" value="http://omero.testdomain.com:4080/"/>

Note: Webstat page is also available when user is not logged in. In this case there will be default server host and port set and no sessionid provided. These parameters should be used as a helper to choose the right server from the list.

cc: @jburel @dominikl

@jburel jburel added the develop label May 13, 2015
@joshmoore
Copy link
Member

In general, big 👍 for this @aleksandra-tarkowska. The only caveat that might arise is the need for a static webstart page so that we can sign it: https://trello.com/c/4KjZpcX2/494-sign-webstart-jnlp-file

@atarkowska
Copy link
Member Author

@joshmoore There is nothing stopping anyone from replacing template by bin/omero config set omero.web.webstart_template as long as we have signed file and test it. First lets see if params works and Insight will be able to use them.

@joshmoore
Copy link
Member

First lets see if params works and Insight will be able to use them.

Makes sense! (Think the hope, though, is that we can provide a signed one, which is going to be tricky)

@dominikl
Copy link
Member

SessionID is now included in the jnlp properties. Good to merge.

@joshmoore
Copy link
Member

Can I propose we leave open until we have the two working together in case there is some back and forth?

@jburel
Copy link
Member

jburel commented May 14, 2015

corresponding insight PR gh-3820

@jburel jburel mentioned this pull request May 14, 2015
@joshmoore
Copy link
Member

./components/tools/OmeroWeb/omeroweb/webstart/views.py:43:1: E302 expected 2 blank lines, found 1
./components/tools/OmeroWeb/omeroweb/webstart/views.py:82:1: E303 too many blank lines (3)
./components/tools/OmeroWeb/omeroweb/webstart/views.py:134:1: E302 expected 2 blank lines, found 0

@joshmoore
Copy link
Member

Assuming that all testing for this PR was commented under #3820, merging.

joshmoore added a commit that referenced this pull request May 25, 2015
@joshmoore joshmoore merged commit 32b2911 into ome:develop May 25, 2015
@joshmoore joshmoore added this to the 5.1.2 milestone May 27, 2015
@atarkowska atarkowska deleted the webstart_credentials branch July 2, 2015 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants