Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jnlp parameters #3820

Merged
merged 10 commits into from May 25, 2015
Merged

Jnlp parameters #3820

merged 10 commits into from May 25, 2015

Conversation

jburel
Copy link
Member

@jburel jburel commented May 14, 2015

Handle the parameters specified when using webstart
To test:

  • Log using the web client
  • Start insight from web
  • After the standard steps, insight splashscreen should only show the progress bar displayed when initializing the internal services. No username/password field
  • When completed, the application should automatically log in and the data manager should pop up.

cc @dominikl @aleksandra-tarkowska
see gh-3810

@atarkowska
Copy link
Member

@jburel Thanks for a quick progress. Looks like on trout is trying to connect to localhost

<property name="jnlp.omero.host" value="localhost"/>
<property name="jnlp.omero.port" value="4064"/>
<property name="jnlp.omero.sessionid" value="8af2a5a8-6b88-48a5-9974-783c262f53b3"/>
<property name="jnlp.omero.web.host" value="http://omero.testdomain.com:4080/"/>

I will need to review that why

@atarkowska
Copy link
Member

This is because ...ci/config/OMERO-5.1-merge-deploy.omero Cannot usee localhost anymore

@jburel
Copy link
Member Author

jburel commented May 15, 2015

The last commits should:

  • hide username/password fields when a session is specified.
  • Show the fields and controls if the connection failed.
  • Display the server name specified via parameters

@joshmoore
Copy link
Member

I haven't gotten the webstart version working yet, @jburel, but 2 questions:

  • if the session is missing/removed, will the user/password dialog reappear?
  • will testing via the CLI, e.g. by passing -Djnlp.omero.host=.... be sufficient?

@jburel
Copy link
Member Author

jburel commented May 18, 2015

  • If no session specified or if we fail to log in using the session idea. Then the "login fields" show up.
  • Currently reading values from System.property. If we want to specify parameters then the code will have to be modified

@atarkowska
Copy link
Member

@jburel looks like #3810 (commits) is working now ;-) Although I forgot to add omero.client.web.host to the jnlp, grrrr. Pushing that now

@atarkowska
Copy link
Member

With the last commit insight can read web host from <property name="jnlp.omero.web.host" value="http://omero.testdomain.com:4080/"/>. This is testing if omero.client.web.host is set, if not then giving omeroweb domain

@ximenesuk
Copy link
Contributor

This works fine for me on my new Mac Java 8, Firefox. (On my old Mac there were too many security hurdles!) However, @mtbc seemed to have a problem so I'll let him comment here.

@mtbc
Copy link
Member

mtbc commented May 19, 2015

Just as a data point, this has no effect for me on Linux with icedtea-web 1.5, I get the Insight login dialog as normal.

@jburel
Copy link
Member Author

jburel commented May 19, 2015

For @mtbc:
after further tests,
The host and port seem to be correctly passed but not the session id.
This results in failing to connect using the session id and in that case we fall back on login fields being displayed.

This seems a bit strange

@mtbc
Copy link
Member

mtbc commented May 20, 2015

I should mention, I had a surprise this morning: launched trout merge webstart (not from logged-in webclient), worked on trout a bit, went to switch user, and the host was "localhost" so I had to switch it back to trout. When I switched user a second time it stayed on trout.

@atarkowska
Copy link
Member

Could you please try both options and open jnlp file to check exactly what was passed through. When you are logged in could you list active sessions on the server and check if session key is there?

@atarkowska
Copy link
Member

Also which JVM you use?

@mtbc
Copy link
Member

mtbc commented May 20, 2015

$ java -version
java version "1.7.0_79"
OpenJDK Runtime Environment (IcedTea 2.5.5) (7u79-2.5.5-1~deb8u1)
OpenJDK 64-Bit Server VM (build 24.79-b02, mixed mode)

@atarkowska
Copy link
Member

@jburel does it make sense to add debug mode in jnlp at some point? Could you give me some details wow that would work?

@mtbc
Copy link
Member

mtbc commented May 20, 2015

Not logged in:

$ grep property insight.jnlp
    <property name="jnlp.omero.host" value="trout.openmicroscopy.org"/>
    <property name="jnlp.omero.port" value="4064"/>
    <property name="jnlp.omero.web.host" value="https://trout.openmicroscopy.org/merge/"/>

Logged in:

$ grep property insight.jnlp
    <property name="jnlp.omero.host" value="trout.openmicroscopy.org"/>
    <property name="jnlp.omero.port" value="4064"/>
    <property name="jnlp.omero.web.host" value=""/>
    <property name="jnlp.omero.sessionid" value="b4f6879e-9cf2-43cb-bf27-2a7f1ddde7e9"/>

I can't work out how to work bin/omero sessions list to see the active sessions. Can you check on trout merge?

@joshmoore
Copy link
Member

bin/omero sessions list shows sessions local to your CLI. bin/omero sessions who shows sessions on the server.

@mtbc
Copy link
Member

mtbc commented May 20, 2015

Ah, "who" needs a very recent develop! Thank you for the help.

user-2 | private-1 | 2015-05-20 15:52:18     | OMERO.web      | 10 min. | 386      | 2015-05-20 16:36:22 

looks to be the promising line, fits well when I would have logged in.

@joshmoore
Copy link
Member

Just a thought: do we know that one use of the session won't interfere with the other client (i.e. closing, etc)?

@atarkowska
Copy link
Member

@mtbc
Copy link
Member

mtbc commented May 22, 2015

@jburel seems to be on the case but I'm generally happy to type in and try things.

@atarkowska
Copy link
Member

@joshmoore launching Insight with the same session key doesn't kill the session. We have just checked that with @mtbc session was alive, even more when he paste that session key to insight as a username he managed to log in. That shows another issue that when he logged out from Insight the session wasn't killed ;-)

@jburel
Copy link
Member Author

jburel commented May 22, 2015

@aleksandra-tarkowska: we have a card for that session problem see https://trello.com/c/NWT3qUma/430-client-del-session-still-alive

@joshmoore
Copy link
Member

Sounds good. Thanks for this, everyone!

joshmoore added a commit that referenced this pull request May 25, 2015
@joshmoore joshmoore merged commit b869d7d into ome:develop May 25, 2015
@mtbc
Copy link
Member

mtbc commented May 26, 2015

For what it's worth, this does seem to work fine for me on Linux if I switch to using the javaws from my old Oracle JDK 6 installation.

@joshmoore
Copy link
Member

And this works for me for local dev testing:

components/insight/build$ ant run -Dapp.vmparameters="-Djnlp.omero.port=14064 -Djnlp.omero.host=localhost -Djnlp.omero.sessionid=17a7..."

@joshmoore joshmoore added this to the 5.1.2 milestone May 27, 2015
@jburel jburel deleted the jnlp-parameters branch June 11, 2015 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants