Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save z changes #3855

Merged
merged 4 commits into from Jun 18, 2015
Merged

Save z changes #3855

merged 4 commits into from Jun 18, 2015

Conversation

dominikl
Copy link
Member

Enables the save button after Z or T has been changed. There are still some minor issues with the z/t sliders if both views (preview and full viewer) are open at the same time (z/t slider then shows the last selected z/t state, even if the z/t changes haven't been stored), not going to fix that in this PR.

@pwalczysko
Copy link
Member

2 issues:

  1. RFE: Even when the video player button in the Full Viewer is used for z/t change, enable the Save button
  2. Conceptual issue: I think we agreed that the Save to All action should NOT propagate the same z/t selection over all the images in the Dataset -> but this is now the case unfortunately

@pwalczysko
Copy link
Member

cc @gusferguson @jburel @will-moore

@dominikl
Copy link
Member Author

RE 1) Will implement this within this PR;
RE 2) Not related to this PR, PR just enables the save button, does not modify any logic about saving rendering settings.

@jburel jburel added the develop label May 29, 2015
@pwalczysko
Copy link
Member

Works as expected even with video button. Ready to merge.

jburel added a commit that referenced this pull request Jun 18, 2015
@jburel jburel merged commit 4bf8819 into ome:develop Jun 18, 2015
@sbesson sbesson added this to the 5.1.3 milestone Jul 17, 2015
@dominikl dominikl deleted the save_z_changes branch August 21, 2015 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants