Share editing 8790 #386
Share editing 8790 #386
Conversation
Webstart fixes (thanks to Mark Woodbridge)(cherry picked from commit 781def9)
This commit fixes both the issue that Alex Herbert raised on ome-devel and an issue with OMERO.insight or OmeroJava being able to download files > 2.1GB. (cherry picked from commit c0cd3e7)
During the "package" phase of the build, the regular
jar does not exist. Only `${ivy.module}-UNSIGNED`
exists. The "install" phase turns the unsigned version
into the final version.
(cherry picked from commit ee20324)
(cherry picked from commit c5a2e9d)
These change are only used by the OMERO-4.4-virtualbox job to download the proper build (in this case that produced by the OMERO-4.4 build)
Release version 4.4.4 Conflicts: components/bioformats components/insight/SRC/org/openmicroscopy/shoola/env/data/OMEROGateway.java components/tools/OmeroImageJ/Omero_ImageJ/build.xml
|
All four points checked. All okay other than notes below. It's probably worth rechecking point 1 once the day in the month isn't 1 - ie it correctly wouldn't let me go back to September but tomorrow will it let me pick Oct 1? Image count looks okay with newly created shares. But there is an old share in there (user-4) that reports 13 images but there are only 4 there. Is this because 7 have been deleted? I.e. is the count the current number of images in the share or the original number? |
|
The date-picker doesn't assume today is 1st (was working OK last week). The image count issue was a bug in share creation, so old shares may still exhibit this bug but new ones shouldn't. |
|
@ximenesuk, anything left to check? |
|
@joshmoore No, just absolutely checked that today I can't select earlier days this month. So it's good to go. |
This statement seems responsilble to adding omero.model.FormatI objects to the share as retrieved by shareService.getContents(sid). These add to the content count but are not displayed in web because we filter for images only. According to Josh, the addObjects() method is old and should not be needed anymore but 'no promises - needs testing'.
No ticket for this, but I just found it really annoying not being able to see which image is which in the basket (when the basket content drop-down has already loaded them)
Fixes a couple of issues when editing shares #8790 and image count #9614