Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging fixes #3880

Merged
merged 2 commits into from Jun 25, 2015
Merged

Tagging fixes #3880

merged 2 commits into from Jun 25, 2015

Conversation

dominikl
Copy link
Member

  • Enables Tagset selection on import stage, see Ticket 12920; Test: Create a Tagset, open the import dialog, and make sure you can see and select the tagset there.
  • Fixes a problem that tagged plates disappeared from the tree view after switching and returning to the Tag browser. Test: Tag a plate; switch to the Tags browser; expand the tag the plate was tagged with and make sure the plate is displayed as a sub node of the tag node. Switch to another browser, Search, Screens, whatever. Return to the Tags browser and make sure it still looks like before (tag node expanded showing the plate).
    See Trello - Tagging problems

@joshmoore
Copy link
Member

Kicked travis. See gh-3882.

@jburel jburel added the develop label Jun 19, 2015
@pwalczysko
Copy link
Member

  • Tagset problem: Works fine.
  • Plate in Tagtree problem : Principally all works fine, except ordering:
    • Before I navigate to another tab (like Search etc.), the Plates are ordered alphabetically with images, datasets etc. in between
    • After I navigate to another tab, the ordering is changed -> now the Plates are listed separately at the end of the tree

Suggest: Unify the ordering, preferably the same way as it is in other tabs (==Plates separately, images separately, datasets separately.... etc.)

Bafore navigating somewhere else

screen shot 2015-06-22 at 11 09 53

After navigating somewhere else

screen shot 2015-06-22 at 10 36 36

@dominikl
Copy link
Member Author

Apparently a small change, but it looks like nearly impossible to me at the moment. I'd suggest to postpone the ordering problem to another, separate PR.

@pwalczysko
Copy link
Member

In that case, happy to merge.

@jburel
Copy link
Member

jburel commented Jun 25, 2015

Sorting the nodes can be done in another PR. Merging

jburel added a commit that referenced this pull request Jun 25, 2015
@jburel jburel merged commit e0d810a into ome:develop Jun 25, 2015
@sbesson sbesson added this to the 5.1.3 milestone Jul 17, 2015
@dominikl dominikl deleted the tagging_fixes branch August 21, 2015 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants