Share editing 8790 #396
Share editing 8790 #396
Conversation
This statement seems responsilble to adding omero.model.FormatI objects to the share as retrieved by shareService.getContents(sid). These add to the content count but are not displayed in web because we filter for images only. According to Josh, the addObjects() method is old and should not be needed anymore but 'no promises - needs testing'.
No ticket for this, but I just found it really annoying not being able to see which image is which in the basket (when the basket content drop-down has already loaded them)
|
Tested. Works as expected, but cannot test "choose new exp-date" in expired share aspect yet as I have to wait until the share I set up today expires. Will check that on Monday. |
|
@gusferguson: did you have a chance to test it today? If so what is the outcome? |
|
Tested expired share this morning - behaved as expected. |
|
@gusferguson: Ready to merge? |
|
@jburel - I can test today |
|
Tested following build - expiry date and reset still working as expected - no problems from owner or other share users perspectives. Did notice problem with thumbnails in centre pane using IE in Win 7 - there is nothing separating thumbnails - in Safari on Mac there is a this white line between thumbnails. There is also no other information about the image shown in the list view in contrast to Data list view where you see image name etc next to thumbnails. Screenshots: squig>team>screenshots>4.5_Sprint1>Gus>Webclient-share-mac.jpg and Webclient-share-win7.jpg |
|
Tested on howe. The share logic from the commits is in place. As Gus reported - the Public data view (middle panel in the web client) is currently unusable. The images are displayed in a single column. There is no indication which image is selected in the tree. There is no border around images. This PR is ready to merge. |
|
The share-editing-public-data-view issues as reported by Blazej and Gus are resolved |
Rebased old branch #386 onto dev_4_4 by cherry-picking all commits.