sudo sessions timeout

[dominikl]

See Ticket 12972
Previously if a session for another user was created a zero timeout was set, with this PR now the same timeout as the existing session is used.
Test: Code review, check that the import as other user (will initiate a sudo session) still works.

[sbesson]

This method apparently sets the timeToLive and you are setting the timeToIdle from the first session, you might want to use createSessionWithTimeouts(principal, long, long) instead.

[dominikl]

Thanks @sbesson , didn't notice that; fixed now.

[sbesson]

Using the OMERO.insight from https://ci.openmicroscopy.org/view/DEV/job/OMERO-DEV-merge-build/66/ (OS X), imported an image as another user

$ bin/omero sessions -q who
 name    | group           | logged in               | agent          | timeout | hitCount | lastAccessTime      
---------+-----------------+-------------------------+----------------+---------+----------+---------------------
...
 user-11 | read-annotate-1 | 2015-08-21 07:35:56     | createSession  | 10 min. | 28       | 2015-08-21 07:35:57 
 root    | system          | 2015-08-21 07:34:03     | OMERO.insight  | 10 min. | 63       | 2015-08-21 07:36:04 
07:41:43 
 user-11 | read-annotate-1 | 2015-08-21 07:34:52     | createSession  | 10 min. | 337      | 2015-08-21 07:35:56 
(13 rows)

And the sudoed sessions timeout after 10 minutes of inactivity as expected. 👍

[dominikl]

Just agent "createSession" looks a bit weird, wonder where that comes from...

[sbesson]

This agent is set by https://github.com/openmicroscopy/openmicroscopy/blob/v5.1.3/components/server/src/ome/services/sessions/SessionBean.java#L119. We might want to add extra methods allowing to control the agent that could be used by clients like CLI, Insight etc

[joshmoore]

Did any of the points (or the need to manually lookup the timeout) get listed as an RFE anywhere?

[jburel]

you mean a card? ticket is http://trac.openmicroscopy.org/ome/ticket/12972

[joshmoore]

Sorry, no. I meant the other RFEs.

[sbesson]

See https://trello.com/c/azP0udku

[dominikl]

--rebased-to #4086