Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Import As freezes #4316

Merged
merged 8 commits into from
Nov 10, 2015
Merged

Bugfix: Import As freezes #4316

merged 8 commits into from
Nov 10, 2015

Conversation

dominikl
Copy link
Member

Fixes Ticket 12929
Problem: After an object has been saved the connector was shutdown. This could lead to an abortion of a parallel running import job. This PR removes the connector shutdown, because it's actually not necessary at that point anyway.

Test:
Follow the workflow which previously triggered this bug, which is:

  • Log in as a group owner or administrator
  • Start (not just add to the queue) a long running import job for another user
  • Now start another import for the user you're logged in with, but import into a particular dataset which you have to create first on the import dialog (this caused the crash)
  • Make sure the imports are passing like expected.

Note: The actual bugfix is just commit 979098b . The first commits add PropertyChangeSupport to the Gateway, i. e. one can add a PropertyChangeListener to the Gateway for debugging purposes, which makes it much easier to monitor what's going on in the Gateway. Any objections on this?

/cc @jburel

@jburel jburel added the develop label Oct 30, 2015
@joshmoore
Copy link
Member

[nomemoryjava] /home/travis/build/openmicroscopy/openmicroscopy/components/blitz/src/omero/gateway/Gateway.java:70: error: cannot find symbol
[nomemoryjava] import omero.gateway.util.GatewayMonitor;
[nomemoryjava]                          ^
[nomemoryjava]   symbol:   class GatewayMonitor
[nomemoryjava]   location: package omero.gateway.util

@jburel
Copy link
Member

jburel commented Nov 4, 2015

making debugging easier makes sense

* @param context The context hosting information about the user.
* @param secureClient The entry point to server.
* @param entryEncrypted The entry point to access the various services.
* @param encrypted The entry point to access the various services.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's just a boolean

@mtbc
Copy link
Member

mtbc commented Nov 4, 2015

Functionally works fine, just a comment nitpick.

@mtbc
Copy link
Member

mtbc commented Nov 4, 2015

Good to merge.

@dominikl dominikl mentioned this pull request Nov 4, 2015
@jburel
Copy link
Member

jburel commented Nov 10, 2015

Merging so it does not conflict with login work done in gateway.

jburel added a commit that referenced this pull request Nov 10, 2015
@jburel jburel merged commit 4dd8136 into ome:develop Nov 10, 2015
@jburel jburel added this to the 5.2.1 milestone Dec 17, 2015
@dominikl dominikl deleted the gateway_logging branch April 15, 2016 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants