Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata panel followup 1 #4326

Merged
merged 3 commits into from Dec 11, 2015
Merged

Conversation

dominikl
Copy link
Member

See Trello - insight: Right-hand panel follow up

  • Removes the "Save" button from the metadata panel (changes are saved anyway, no need for the button anymore); Test: Make sure the button is gone; add/edit some data, make sure its stored automatically.
  • Fixes "Comments" for multiselection, Ticket 13083; Test: Select multiple dataobjects and add a comment; make sure the comment is added to all objects. Select multiple dataobjects with different comments; make sure you see all comments of all selected objects.
  • Fixes Small bug in Dataset_To_Plate.py. Problem wasn't caused by python script, just the name of wells from plates generated by datasets was wrongly displayed in Insight (off by one). Test: Run the dataset-to-plate script; make sure the names of the wells shown in the metadata panel (A-1, A-2, etc. ) are correct

@jburel jburel added the develop label Nov 10, 2015
@gusferguson
Copy link

@dominikl

Tested using OMERO.insight-5.2.0-68-f34d43c-ice35-b155-win eel user-3 read-only-1

Behaves as expected.

  • no Save button visible with editing metadata
  • multi-selection comments behaving as expected
  • Dataset to plate works as expected

Good to merge.

cc. @will-moore @jburel @pwalczysko - I just noticed that the default for the Dataset to Plate script is to delete images from dataset - option checked by default. I really think this should be unchecked by default - it is destructive and not undo-able so default should be safest option. Should I do a ticket/Trello card for this?

@jburel
Copy link
Member

jburel commented Nov 11, 2015

@gusferguson: this is a part of script review. Please add item to https://trello.com/c/H3lObNDY/10-scripts-review-scripts-with-re

@jburel
Copy link
Member

jburel commented Dec 11, 2015

@gusferguson: does it need new screenshots?

jburel added a commit that referenced this pull request Dec 11, 2015
@jburel jburel merged commit caa3ba8 into ome:develop Dec 11, 2015
@gusferguson
Copy link

@jburel - thanks - I don't think so - I will do a survey of all the screenshots in Help and double-check.

@gusferguson
Copy link

@jburel - ~20 screenshots needed updating - done.

@jburel
Copy link
Member

jburel commented Dec 11, 2015

@gusferguson: thanks

@jburel jburel added this to the 5.2.1 milestone Dec 17, 2015
@dominikl dominikl deleted the metadata_panel_followup_1 branch April 15, 2016 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants