Insight row-wise selection of thumbnails 9195

[manics]

This is a partial fix for #9195. <shift>-clicking with the mouse on the image thumbnails will select consecutive images row-wise, see https://trac.openmicroscopy.org.uk/ome/ticket/9195#comment:1 for details. Drag-selection with the mouse is unchanged, and will select a rectangular group of thumbnails. This applies to both images in datasets and screens.

Testing: Open a dataset with multiple rows of thumbnails, check the above behaviour is seen. Also check the image names in the tree-view are selected in sync.

[gusferguson]

Tested using Windows 7 and Mac versions - both behaved as expected all combinations.

[jburel]

@manics, @gusferguson: selecting the full row on mac is not the behavior of finder when the key is pressed,
on windows it works fine. Probably better to match general behavior

[manics]

@jburel @gusferguson shift-clicking in the Finder icon view behaves the same as Cmd-click (Ctrl-click on Windows), i.e. selecting individual files.

However if you switch to list view shift-click selects consecutive files. Both are arguably correct- although the thumbnails are similar to the icon view in practice users will have a naming system for their files which puts related files together, so consecutive selection would make sense. @rleigh-dundee was the original reporter, any thoughts?

[ghost]

I don't think the Finder is an example of good behaviour here. The files are ordered, and preventing the user from selecting files in a range within that ordered list makes little sense.

[jburel]

@manics, @rleigh-dundee: I like the row selection. (Finder was not a good example I agree) We just need to make sure that we have the expected behavior on the selected OS. Looking at iPhoto, the row selection is implemented. Might be worse checking another imaging tool to be on the save side.

I just looked at a tool called jAlbum.
Everything works as expected.

[jburel]

@manics, @rleigh-dundee, @gusferguson : Roger and I had just a discussion, Roger will do a final check with a photo manager on Debian to be sure that the implementation we have matches other tools' ones.

[jburel]

@rleigh-dundee: did you get a change to test on Debian?

[ghost]

Tested using the Thunar (XFCE) and Dolphin (KDE) file managers, Konqueror file browser (KDE) and the DigiKam photo management software. All behave identically.

All of these do the following:
selection of files in an icon view with a rubber rectangle: uses rectangular selection, ignoring files outside the contiguous range that fall outside the rectangle.
selection of files in an icon view with shift-select will always select the range between first and last selected
selection of files in a compact list view behaves the same as an icon view
selection of files in a detailed list view only allows selection of contiguous ranges

[jburel]

@joshmoore: Ready to merge.