Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses various errors that arise when non-integer values are used in webgateway urls.
The url regex expressions were previously were not ensuring that numbers were used in the url for IDs etc, hence allowing any values to be used.
E.g.
/webgateway/render_thumbnail/3933597/Simon-Josh/
See https://trello.com/c/dPcurAje/41-render-thumbnail-invalid-int
Now, all IDs and sizes in webgateway urls use
[0-9]
to match only numerical values.To test, try to go to that url.
In addition, check that the viewer still works OK, line plot, ROIs etc.
In addition, this fixes https://trello.com/c/H1uBUxL8/39-render-roi-thumbnail-index-out-of-range where you get an error
IndexError: list index out of range
atwebgateway/render_roi_thumbnail/0
. This will now give a simple 404 error (for any ROI ID for which no shapes are found).To test, try to visit that url.