Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webgateway url ids #4417

Merged
merged 3 commits into from
Jan 24, 2016
Merged

Webgateway url ids #4417

merged 3 commits into from
Jan 24, 2016

Conversation

will-moore
Copy link
Member

This addresses various errors that arise when non-integer values are used in webgateway urls.
The url regex expressions were previously were not ensuring that numbers were used in the url for IDs etc, hence allowing any values to be used.
E.g. /webgateway/render_thumbnail/3933597/Simon-Josh/
See https://trello.com/c/dPcurAje/41-render-thumbnail-invalid-int
Now, all IDs and sizes in webgateway urls use [0-9] to match only numerical values.
To test, try to go to that url.
In addition, check that the viewer still works OK, line plot, ROIs etc.

In addition, this fixes https://trello.com/c/H1uBUxL8/39-render-roi-thumbnail-index-out-of-range where you get an error IndexError: list index out of range at webgateway/render_roi_thumbnail/0. This will now give a simple 404 error (for any ROI ID for which no shapes are found).
To test, try to visit that url.

@will-moore will-moore closed this Jan 20, 2016
@will-moore will-moore reopened this Jan 20, 2016
@gusferguson
Copy link

@will-moore

Tested using https://cowfish.openmicroscopy.org/merge/webclient/ user-1 public-group

https://cowfish.openmicroscopy.org/merge/webgateway/render_thumbnail/31851/

Text added on to thumbnail URL - in browser gives 404 error message - in web page gives no image icon.
Viewer works as expected - but could not test the line plot and ROIs as the logistics of getting an image with ROIs into cowfish public defeated me.
Otherwise - behaves as expected.

https://cowfish.openmicroscopy.org/merge/webgateway/render_thumbnail/0/
Gives 404 error page.

Good to merge.

joshmoore added a commit that referenced this pull request Jan 24, 2016
@joshmoore joshmoore merged commit e7eb85b into ome:develop Jan 24, 2016
@jburel jburel added this to the 5.2.2 milestone Feb 29, 2016
@will-moore will-moore deleted the webgateway_url_ids branch February 18, 2019 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants