Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download of archived image (see #9850) #466

Merged
merged 1 commit into from
Nov 7, 2012
Merged

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 6, 2012

Fix critical bug https://trac.openmicroscopy.org.uk/ome/ticket/9850

To test:

  • select an image with name like /usr/foo.dv
  • Make sure the default directory is displayed and not /usr
  • Check that the image can be downloaded
  • Test with an archived image and an image not archived.

@ghost ghost assigned ximenesuk Nov 6, 2012
@ximenesuk
Copy link
Contributor

Looks good. Ready to merge.

jburel added a commit that referenced this pull request Nov 7, 2012
Fix download of archived image (see #9850)
@jburel jburel merged commit c4c5078 into ome:dev_4_4 Nov 7, 2012
@gusferguson
Copy link

Tested using:
http://hudson.openmicroscopy.org.uk/job/OMERO-merge-4.4/54/artifact/src/target/
gretzky
Mac 10.6

Imported 4 files - 2 images - .psd and .dv version of each

Note:

  1. check box to archive on import no longer in import dialogue - therefore expected it to be done automatically
  2. Despite the "Options" tab options being set at default which is: Overide default naming and instead use ... partial with 0 directories before - the files were imported with full path back to "/Users/rkferguson/"

When images imported they were all named with their original file extensions.
On downloading - images were downloaded as .ome.tif (only 1 f)
On exporting they were downloaded as .ome.tiff (2 fs)

So it appears that either archiving is not taking place, and unlike the old version it is allowing downloading even if there is no archived version, or downloading is just using export.

All / directories are stripped from the names for both "download" and export.

Behaviour the same on Windows 7

@jburel
Copy link
Member Author

jburel commented Nov 8, 2012

@gusferguson; Archived is gone with FS. and the links between pixels and files are not done yet. So it is normal to have an OME-TIFF. It works as expected

@jburel
Copy link
Member Author

jburel commented Nov 8, 2012

@gusferguson: Comment should be added to #469. @ximenesuk tested it and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants