Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-viewer zoom buttons #4701

Merged
merged 1 commit into from Aug 15, 2016
Merged

Conversation

will-moore
Copy link
Member

Fixes a bug reported in forum comment at https://www.openmicroscopy.org/community/viewtopic.php?f=6&t=8058&start=10#p17150

This is tested by example and Robot test at webtest PR: ome/omero-webtest#10

This prevents binding click() to any global zoom buttons
@will-moore will-moore changed the title Viewer zoom button clicks bound more specifically multi-viewer zoom buttons Jun 8, 2016
will-moore added a commit to will-moore/weblabs that referenced this pull request Jun 8, 2016
@sbesson sbesson added the develop label Jun 8, 2016
@pwalczysko
Copy link
Member

Tested with the example listed in ome/omero-webtest#10. Works as expected.

@jburel
Copy link
Member

jburel commented Jun 27, 2016

We probably need to discuss the strategy we want to have in place for this "cross repo" testing
A change here might require an adjustment in the test so we need at a minimum some documentation (not only in the PR description)

@sbesson
Copy link
Member

sbesson commented Aug 15, 2016

Card created to come back to the robot tests RFE (discover and run webapp tests). Merging for now.

@sbesson sbesson merged commit 5a8857c into ome:develop Aug 15, 2016
@sbesson sbesson added this to the 5.3.0 milestone Sep 10, 2016
@will-moore will-moore deleted the multi_viewer_zoom_buttons branch February 18, 2019 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants