Add call to notifyObservers before cancelling (Fix #9852) #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test, as it is, passes okay. Ready to merge. |
joshmoore
added a commit
that referenced
this pull request
Nov 13, 2012
Add call to notifyObservers before cancelling (Fix #9852)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an INTERNAL_EXCEPTION message in case of an exception during importCandidates. There are other methods that similarly need fixing, but in order to not confuse things for 4.4.5, I'm omitted those here. (See below for an example)
To test I add a
new RuntimeException("test")just before thecatchblock. There's likely no other easy way to be sure that theimportImagewill throw (in fact, because of the eaten exception, I still don't know what's causing it in the forum post linked to 9852).