Sprint3 web bugs 19 nov

[will-moore]

Various bug fixes... To test so far:

• Edit the Name (or Description) of an Image in the Search or History pages. The save & cancel buttons should be hidden after the edit. NB: Editing in the Tag or P/D/I pages should also update the name of the image in the tree.
• Feedback form should now work in IE8. On way to generate a stack-trace is to search for * in top-right search box.

[manics]

Save/cancel buttons are removed as expected after editting, names in tree are updated, IE8 feedback form works. Can be merged.

RFE: In the image list and search results view (central pane) the names aren't updated.

[jburel]

@will-moore: might make sense to do the RFE as part of this PR.

[will-moore]

@jburel I guess so, yes.

[will-moore]

To properly test the bug-fix in the previous commit, you need to test the python script from this post https://www.openmicroscopy.org/community/viewtopic.php?f=6&t=3402&p=7761#p7719 with the source image in a different group from your default group. However, this is also being tested by Alex (only required by his script), so our priority is to ensure that these changes haven't broken our scripts: E.g. Channel_Offsets.py or Images_From_ROIs.py. Just try running one of these scripts on an image in your default group and another group.

[manics]

Channel_Offsets.py script runs fine. Tested createImageFromNumpySeq() at the command line on a local build with a non-default group, works.

Still waiting for the earlier RFE.

[will-moore]

@chris-allan NB: that previous commit fixes a bug with acquisition and preview tabs being disabled for Wells. Been a bug since 0d774bf.

[manics]

Image names are now updated as expected in history and search, can you also do the same for images displayed as list in Data and Tags view? Also for tooltips in the icon view.

[manics]

Another small issue (sorry, I should have been more thorough when testing yesterday). Tooltips for datasets/projects/screens aren't updated in the Search and History view, though the names are updated correctly.

There's a problem with renaming tags: Selecting a tag in the Tags view (left pane), click to edit the tag name (right panel), server 500 error. Related, or do you want me to open a new ticket?

[will-moore]

@manics The tag renaming fix is in #482. I will look at tooltips in search & history views, Cheers.

[manics]

Ready to merge.

[joshmoore]

@will-moore, do we have tests for the gateway methods which have added SERVICE_OPTS? I looked through them and didn't see anything that would obviously fail, but save methods with group==-1can do strange things depending on what's being passed in.

[will-moore]

All gateway methods should use SERVICE_OPTS, but most tests don't set SERVICE_OPTS. Only the permissions tests check them.

Strictly, we should have every test run across several groups (like the permissions tests) but that's a LOT of work.

Certainly most methods that attempt to save anything would fail if you've got omero.group: -1.

[joshmoore]

Just an aside: if the intent is that every gateway method invocation should pass SERVICE_OPTS then it might be worth making the service wrapper check for it. But that's beyond scope for this PR.