New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spw grid view2 #4924
Spw grid view2 #4924
Conversation
gh-4863 has been merged |
a9b5b9a
to
81ced05
Compare
Data generated with script from dsudar/OMEROscripts#1 |
Tested using http://10.0.51.106/web/webclient/userdata/?experimenter=2 user-1 jpeg-xr group Safari 2007.10.17.17.04.55.xdce and other data. Birdseye view shows spatial arrangement of fields when selected. In the birdseye shift-click for multi selection does not work in Safari/Firefox/Chrome but cmd-click and click-drag both work. All highlighting appears appropriate. Wrapping of thumbnails in well rows behaves as expected. Could we reduce or remove the corner rounding on the wrap text box? - because it is so short it looks oval All other functionality works as expected. Good to merge from my POV. |
Robots are failing in https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-robotframework/438/console. Where does |
Tested using http://web-dev-merge.openmicroscopy.org/webclient/ user-5 and user-1 Behaves as expected. Good to merge. |
Conflicting PR. Removed from build OMERO-DEV-merge-push#532. See the console output for more details.
|
@@ -45,6 +47,34 @@ echo "A2,Treatment,10" >> "$BULK_ANNOTATION_CSV" | |||
# Create file for upload as File Annotation | |||
echo "Robot test file annotations" > "$FILE_ANNOTATION" | |||
|
|||
# Create a python script for setting posX and posY on wellsamples | |||
# Used below after importing a plate | |||
WELLSCRIPT="wsScript.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be better to have the script in a separate file so it is easier to understand and potentially re-use if need be
#wellImages li { | ||
display: inline-block; | ||
} | ||
#wellImages ul, #wellImages h1{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space
few minor comments |
Check typos and check robot tests (spw_test). |
@@ -71,7 +71,7 @@ Test Spw Grid Layout | |||
Should Be Equal ${well1x} ${well5x} | |||
|
|||
|
|||
Test Spw Spacial Birds Eye | |||
Test Spw Spatial Birds Eye | |||
[Documentation] Tests layout and clicking of 'spacial bird's eye' panel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more spacial
'spacial bird's
one more typo. If we have more scripts required for testing, we may want to create a |
path to script
Remove extra ")"
The commits above fix the setup issue. Other failures in the robot tests. |
@@ -179,6 +183,7 @@ | |||
// jsTree code in ome.tree.js and center panel code in center_plugin.thumbs.js.html uses initially_select | |||
// instead of browser URL since URL may be /webclient/?path=plate.name-barcode|well.name-A1 | |||
WEBCLIENT.initially_select = [{% for o in initially_select %}"{{ o }}"{% if not forloop.last %},{% endif %}{% endfor %}]; | |||
WEBCLIENT.initially_open = [{% for o in initially_open %}"{{ o }}"{% if not forloop.last %},{% endif %}{% endfor %}]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed recently, constructing array this way is inconvenient, see #5018
@will-moore is this PR ready to be merged? Either could you please cherry-pick #5018 here or let's merge and I will fix the above in my PR. It is the only way I managed to pass non digits. |
Spatial view of fields in Wells
2nd PR working towards ome/design#52
Builds on #4863
Also see https://trello.com/c/GxqDnD0P/211-spw-follow-up
To test:
TODO: