Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel processor #5084

Merged
merged 8 commits into from Feb 8, 2017
Merged

Channel processor #5084

merged 8 commits into from Feb 8, 2017

Conversation

jburel
Copy link
Member

@jburel jburel commented Feb 3, 2017

What this PR does

This PR sets the default color in RGB in sequence when more than 3 channels
instead of RGBBBB etc.

Testing this PR

  • Integration test checking that the values are correctly set when using the rendering service
  • unit test for channel processor change
  • Import one of the images below and check that the channels are RGB RGB
  • Open and image and change the color. Save the settings. Reset the default

Related reading

See https://www.openmicroscopy.org/community/viewtopic.php?f=13&t=8210
and https://www.openmicroscopy.org/community/viewtopic.php?f=13&t=8211

cc @sbesson @bramalingam

@jburel jburel changed the title Colorprocessor Channel processor Feb 3, 2017
@jburel jburel added the develop label Feb 7, 2017
@jburel jburel mentioned this pull request Feb 7, 2017
@bramalingam
Copy link
Member

Everything looks good! Looks good to merge.

@jburel
Copy link
Member Author

jburel commented Feb 8, 2017

@chris-allan: this proposed change will turn the multi-channels images to RGBRGB.. instead of RGBBBBB... if no color found in the file or no metadata in the file found to set the color e.g. Jerry's 30 channels image

@jburel jburel merged commit c4d3e2e into ome:develop Feb 8, 2017
@jburel jburel added this to the 5.3.0 milestone Mar 29, 2017
@jburel jburel deleted the colorprocessor branch August 1, 2017 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants