Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the hidden file restrictions #5199

Merged
merged 1 commit into from Apr 5, 2017

Conversation

dominikl
Copy link
Member

@dominikl dominikl commented Mar 24, 2017

What this PR does

For some reason Insight/Importer didn't allow to import hidden files (which includes files in hidden directories). This PR removes this restriction.

Testing this PR

Has to be tested on Windows. Linux and OSX don't show the hidden folders/files in the import dialog in first place, but Windows does if you set the Windows Explorer to do so.

  • Create a hidden folder and put some image files into it.
  • Import them via Insight and/or Importer.

Related reading

http://lists.openmicroscopy.org.uk/pipermail/ome-users/2017-March/006399.html

@jburel jburel added the develop label Mar 27, 2017
@kennethgillen
Copy link
Member

👍 @dominikl

Successfully imported hidden files in a hidden folder on Windows Server 2008 R2, equivalent to Windows 7.

screen shot 2017-03-30 at 11 31 30

@dominikl
Copy link
Member Author

Thanks for testing @kennethgillen !

@jburel
Copy link
Member

jburel commented Apr 3, 2017

Do we want a note in the help
i.e. http://help.openmicroscopy.org/importing-data-5.html

@jburel jburel merged commit 5ef5218 into ome:develop Apr 5, 2017
@jburel jburel added this to the 5.3.1 milestone Apr 20, 2017
@dominikl dominikl deleted the enable_hiddenfile_import branch May 3, 2017 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants