Modulo retrieve #576
Modulo retrieve #576
Conversation
Method useful to retrieve annotation like modulo annotation added at import time.
|
@jburel, what's the argument for putting this on 4.4? I'm a bit worried about what this does to client/server interactions between new and old versions. |
|
@joshmoore: I do not have the intention to support it in our client. Ian needs to move forward in his support for FLIM. |
|
Sure, but regardless of whether or not it's in the clients, it still has an impact on the generated code. Let's at least be sure we test what happens between different versions before merging. |
|
@joshmoore: of course. It is a new method, existing methods have not be modified. |
|
All tests passed |
|
Changes look ok. |
|
@imunro: Is the newly added method what you were expected (cf.discussion before christmas)? |
|
Considering the generic nature of the method and its potential to be used by any, if not all, clients perhaps we could be a bit more thorough with the documentation? At least trying to be as thorough as |
|
It does look as if it will do exctly what we want thanks guys. I should say that this isn't holding us up. It is possible to get the same info with existing methods although it's a bit long winded. |
|
@imunro, @joshmoore: I misunderstood. I thought it was a blocker. in that case I might only add the method to develop and not to a point release. |
|
@joshmoore, @imunro: Discussed with Ian, easier to do against develop. J-M to help Ian to use Iquery in the meantime if required. |
Add method to load given type of annotations linked to objects.
see https://trac.openmicroscopy.org.uk/ome/ticket/10043
In this PR:
To test the PR, run
and (for missing XmlAnnotation support)