Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editinplace bugs #591

Merged
merged 10 commits into from
Jan 15, 2013
Merged

Editinplace bugs #591

merged 10 commits into from
Jan 15, 2013

Conversation

will-moore
Copy link
Member

Fix several issues with editing of Name & Description for Project, Dataset, Image, Screen, Plate, Well(Image) and Tag.

  • #10060 Try save empty Name, Save button shouldn't be disabled.
  • 10061 Save empty Description, should see placeholder 'Add Description'

  • 10063 For object with no name (E.g. edited via API) try to add name in web

  • 10064 All objects with no description should have 'Add Description' placeholder

  • 10066 The edit-description Cancel button should appear same as Save button

  • Also, when editing name, the original name label should be hidden.

@pwalczysko
Copy link
Member

Works as expected except following 2 issues.

1 issue in all browsers:

In all browsers (Safari on Mac, Chrome on XP...) strange behavior of Save and Cancel buttons in Editname in #10063 case:

The #10063 case does not produce errors any more, but after editing the empty string name and putting the new string into the field, the Save button is not available - when pressed, it stays "pressed in", no action is performed. When afterwards the Cancel button is pressed, the new name is respected and saved. Also trying to rename the just newly named object, this strange behavior of Save/Cancel button persists for this particular object. Tried on Image. See screenshot.
Chrome-Editname Save not working
Safari-Mac-Editname Save not working

1 issue in IE8 WinXP:

The #10066 problem is not solved at all in IE8. See screenshot.
IE8 Cancel button Editdescript working but grey

@pwalczysko
Copy link
Member

Tested on Safari Mac OS 10.8, Chrome WinXP, IE8 WinXP.
Both issues mentioned above are resolved. Works fine. Ready to merge.

joshmoore added a commit that referenced this pull request Jan 15, 2013
@joshmoore joshmoore merged commit ed4e004 into ome:dev_4_4 Jan 15, 2013
@joshmoore joshmoore deleted the editinplace_bugs branch January 15, 2013 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants