Split view 10094 #610
Closed
Split view 10094 #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
January 15, 2013 13:51
It was inconsistent to have the first key:value pair be ...key & ...value and then have ...key1 & ...value1 etc. Now, the first ones are ...key0 and ...value0.
Also update the grey panels code (channels not in merged appear grey in split columns)
Merged
|
@will-moore The labels down the left hand side of the figure produced are illegible if the image name is too long. |
|
@will-moore The channel name does not appear in the window when the channel is 'white' I've highlighted the section below. Tested with user-10 on howe with images 9537, 9538 (http://howe.openmicroscopy.org.uk/webclient/?show=image-9538|image-9537) |
|
I'm going to close this until after our next point release (this won''t be included). Especially since this is causing merge conflicts. |
|
https://trac.openmicroscopy.org.uk/ome/ticket/10237 Bug with this PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the first 'Figure Script' to the web client: Split View Figure, providing the same functionality as in Insight, but a more complete figure preview is shown and updated while editing parameters.
This also includes some re-arrangement of the right panel to include the "Publications options" button in a nascent toolbar at the top. Split View Figure script should only be enabled if a suitable Image(s) is chosen.
To test, run the Split View Figure script with one (or more) Images, checking that various parameters are updated in the UI when editing them (except Z-projection, Figure Name, format, Width & Height etc) and they have the same affect on the final figure.