Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download original file fs #743

Merged
merged 5 commits into from
Feb 19, 2013
Merged

Conversation

jburel
Copy link
Member

@jburel jburel commented Feb 14, 2013

Cherry-picked commit from #717 and support for fs.
Since we do not have yet a server with pre-fs data, you will only be able to test the additional commit i.e.
Import an image using fs and download it.

@pwalczysko
Copy link
Member

User-6 on gretzky, build #167.

Tried couple of formats

for single images(.dv, jpeg)
for multi-image files (liff, lei)

All the same result: Activities window reports "Unable to download..". No file downloaded.
Screen Shot 2013-02-15 at 11 38 57

From Insight.log

2013-02-15 11:42:37,661 INFO  [y.shoola.env.data.login.LoginServiceImpl] (nitializer) Logged onto OMERO at: gretzky.openmicroscopy.org.uk
User Name: user-6 -- Password: ***

2013-02-15 11:47:28,186 DEBUG [opy.shoola.env.data.OmeroDataServiceImpl] ( Thread-82) /Volumes/mac-hd/Users/petr/15-02-13/
2013-02-15 11:48:06,359 DEBUG [opy.shoola.env.data.OmeroDataServiceImpl] ( Thread-89) /Volumes/mac-hd/Users/petr/15-02-13/
2013-02-15 11:49:13,115 INFO  [       ome.formats.importer.ImportConfig] ( Thread-92) OMERO Version: 4.4.4-1302-19b6469-dirty-ice33-b167
2013-02-15 11:49:13,116 INFO  [       ome.formats.importer.ImportConfig] ( Thread-92) Bioformats version: 4.5-DEV revision: e35bb2d date: 15 February 2013
2013-02-15 11:49:13,125 INFO  [   ome.formats.importer.ImportCandidates] ( Thread-92) Depth: 4 Metadata Level: MINIMUM
2013-02-15 11:49:13,132 DEBUG [                  ome.scifio.io.Location] ( Thread-92) Location.mapFile: embedded-stream.raw -> null
2013-02-15 11:49:13,141 DEBUG [     ome.scifio.io.NIOByteBufferProvider] ( Thread-92) Using mapped byte buffer? false
2013-02-15 11:49:14,040 INFO  [              loci.formats.FormatHandler] ( Thread-92) DeltavisionReader initializing /Volumes/mac-hd/Volumes/ome/data_repo/test_images_good/dv/CFPNEAT01_R3D.dv
2013-02-15 11:49:14,076 INFO  [              loci.formats.FormatHandler] ( Thread-92) Reading header
2013-02-15 11:49:14,081 INFO  [              loci.formats.FormatHandler] ( Thread-92) Populating core metadata
2013-02-15 11:49:14,081 INFO  [              loci.formats.FormatHandler] ( Thread-92) Reading extended header
2013-02-15 11:49:14,083 INFO  [              loci.formats.FormatHandler] ( Thread-92) Populating original metadata
2013-02-15 11:49:14,084 INFO  [              loci.formats.FormatHandler] ( Thread-92) Populating OME metadata
2013-02-15 11:49:14,107 DEBUG [                  ome.scifio.io.Location] ( Thread-92) Location.mapFile: embedded-stream.raw -> null
2013-02-15 11:49:14,108 INFO  [   ome.formats.importer.ImportCandidates] ( Thread-92) 1 file(s) parsed into 1 group(s) with 1 call(s) to setId in 980ms. (983ms total) [0 unknowns]
2013-02-15 11:49:14,109 INFO  [       ome.formats.importer.ImportConfig] ( Thread-92) OMERO Version: 4.4.4-1302-19b6469-dirty-ice33-b167
2013-02-15 11:49:14,109 INFO  [       ome.formats.importer.ImportConfig] ( Thread-92) Bioformats version: 4.5-DEV revision: e35bb2d date: 15 February 2013
2013-02-15 11:49:14,261 INFO  [       ome.formats.importer.ImportConfig] ( Thread-92) OMERO Version: 4.4.4-1302-19b6469-dirty-ice33-b167
2013-02-15 11:49:14,261 INFO  [       ome.formats.importer.ImportConfig] ( Thread-92) Bioformats version: 4.5-DEV revision: e35bb2d date: 15 February 2013
2013-02-15 11:49:29,946 DEBUG [                  ome.scifio.io.Location] ( Thread-92) Location.mapFile: embedded-stream.raw -> null
2013-02-15 11:49:29,958 DEBUG [                  ome.scifio.io.Location] ( Thread-92) Location.mapFile: embedded-stream.raw -> null
2013-02-15 11:50:04,476 DEBUG [opy.shoola.env.data.OmeroDataServiceImpl] (Thread-104) /Users/petr/15-02-13/

@jburel
Copy link
Member Author

jburel commented Feb 18, 2013

This works with local server (branch of 65b4a2a). Another PR might have introduced an issue on gretzky.

Prepare the call so it is easier to merge to FS branch
* if no archived, indicate to load as OME-TIFF
* if more than one image, create a zip.
Modify the download archived method.
@jburel
Copy link
Member Author

jburel commented Feb 18, 2013

@pwalczysko, @mtbc: rebase the PR onto develop. The problem is currently in develop See https://trac.openmicroscopy.org.uk/ome/ticket/10413

@scottlittlewood
Copy link
Contributor

@jburel @pwalczysko @mtbc Download of original file worked with gretzky build (b169).

Downloaded image was correct size and imported correctly afterwards. Meta data was the same.

2013-02-19_download_original_gretzky

joshmoore added a commit that referenced this pull request Feb 19, 2013
@joshmoore joshmoore merged commit 14ccccf into ome:develop Feb 19, 2013
@sbesson sbesson modified the milestones: 5.0.0, 5.0.0-alpha1 Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants