Get C++ integration tests passing

[JesseCorrington]

This gets all the tests that should pass passing. There will still be some failures due to server bugs. The following should fail.

[ FAILED ] SearchTest.testOnlyAnnotatedWithMultiple
[ FAILED ] SearchTest.testExperimenterDoesntTryToLoadOwner
[ FAILED ] SearchTest.testLookingForExperimenterWithOwner

[joshmoore]

Not necessarily for this PR, but this is a candidate for a helper method (in the fixture or eventually in the gateway)

[joshmoore]

Generally looks fine. @JesseCorrington, in other cases we've disabled known failing tests and filed a ticket. We might consider doing that here, so you can start from a clean(ish) slate.

[JesseCorrington]

Disabling the tests seems to make sense, considering they're server bugs. I'll file a ticket for each issue and then disable test test cases with a note about which tickets they're waiting on.

[JesseCorrington]

Disabled failing tests and everything is now passing.

[joshmoore]

Checking out and running locally...

[joshmoore]

NB: I completely skimped on the formatting for

PTHREAD_CFLAGS:  ['-pthread']
PTHREAD_LIBFLAGS:  ['-pthread']

if you would like to make it not so obnoxious.

[joshmoore]

test/integration/search.cpp: In member function ‘virtual void SearchTest_testByGroupForTags_Test::TestBody()’:
test/integration/search.cpp:249: warning: ‘changePermissions’ is deprecated (declared at target/omero/api/IAdmin.h:2501)
test/integration/search.cpp: In member function ‘virtual void SearchTest_testByTagForGroup_Test::TestBody()’:
test/integration/search.cpp:338: warning: ‘changePermissions’ is deprecated (declared at target/omero/api/IAdmin.h:2501)

omero::cmd::Chgrp() replaced this method call, similar to Delete().

[joshmoore]

Otherwise, compile is fine:

BUILD SUCCESSFUL
Total time: 33 minutes 23 seconds
Josh-Moores-MacBook-Pro:_dev_4_4 moore$ cd components/tools/OmeroCpp/
Josh-Moores-MacBook-Pro:OmeroCpp moore$ scons test
scons: Reading SConscript files ...
Debug setting: True (None)
Checking for C++ header file Ice/Ice.h... (cached) yes
Checking for pthread (-pthread)...(cached) yes
PTHREAD_CFLAGS:  ['-pthread']
PTHREAD_LIBFLAGS:  ['-pthread']
64-Bit build: True (None)
scons: done reading SConscript files.
scons: Building targets ...
Compiling test/gtest/gtest-all.o
Compiling test/gtest/gtest_main.o
Compiling test/integration/ClientUsageTest.o
Compiling test/integration/annotations.o
Compiling test/integration/api.o
Compiling test/integration/beta3.o
Compiling test/integration/chgrp.o
Compiling test/integration/cmdcallbacktest.o
Compiling test/integration/counts.o
Compiling test/integration/delete.o
Compiling test/integration/guest.o
Compiling test/omero/fixture.o
Compiling test/integration/permissions.o
Compiling test/integration/rendering_settings_test.o
Compiling test/integration/search.o
...
Compiling test/integration/sessions.o
Linking   test/integration/integration
Compiling test/unit/client.o
Compiling test/unit/concurrency.o
Compiling test/unit/model.o
Compiling test/unit/operators.o
Compiling test/unit/parameters.o
Compiling test/unit/perms.o
Linking   test/unit/unit
scons: done building targets.

And I had an abort:

Josh-Moores-MacBook-Pro:OmeroCpp moore$ test/integration/integration 
Running main() from gtest_main.cc
[==========] Running 44 tests from 13 test cases.
[----------] Global test environment set-up.
[----------] 5 tests from ClientUsageTest
[ RUN      ] ClientUsageTest.testClientClosedAutomatically
[       OK ] ClientUsageTest.testClientClosedAutomatically (843 ms)
[ RUN      ] ClientUsageTest.testClientClosedManually
[       OK ] ClientUsageTest.testClientClosedManually (788 ms)
[ RUN      ] ClientUsageTest.testUseSharedMemory
[       OK ] ClientUsageTest.testUseSharedMemory (1445 ms)
[ RUN      ] ClientUsageTest.testCreateInsecureClientTicket2099
[       OK ] ClientUsageTest.testCreateInsecureClientTicket2099 (1710 ms)
[ RUN      ] ClientUsageTest.testGetStatefulServices
[       OK ] ClientUsageTest.testGetStatefulServices (2625 ms)
[----------] 5 tests from ClientUsageTest (7411 ms total)

[----------] 2 tests from AnnotationTest
[ RUN      ] AnnotationTest.tagAnnotation
[       OK ] AnnotationTest.tagAnnotation (3109 ms)
[ RUN      ] AnnotationTest.fileAnnotation
[       OK ] AnnotationTest.fileAnnotation (3384 ms)
[----------] 2 tests from AnnotationTest (6493 ms total)

[----------] 1 test from ApiTest
[ RUN      ] ApiTest.VectorArgs
[       OK ] ApiTest.VectorArgs (1 ms)
[----------] 1 test from ApiTest (1 ms total)

[----------] 1 test from Beta3Test
[ RUN      ] Beta3Test.SavingPixels
[       OK ] Beta3Test.SavingPixels (2827 ms)
[----------] 1 test from Beta3Test (2827 ms total)

[----------] 1 test from ChgrpTest
[ RUN      ] ChgrpTest.testSimpleChgrp
integration(59084,0x7fff70943cc0) malloc: *** error for object 0x106a1bca0: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
Abort trap

Thoughts?

[joshmoore]

Ice 3.3.1

[JesseCorrington]

No idea why you're getting an abort in that test, as this change didn't even touch it. Were you able to run the tests before this change?

[joshmoore]

That's a very good question, but one I don't know the answer to (right now). Happy to move this to a ticket if you'd rather handle it there. Alternatively, I can try to run again, and provide you a stack trace.

[JesseCorrington]

Sure, go ahead and move it to a ticket. I'll need to try running it with Ice 3.3 to see if I can even repro the issue.

On Feb 18, 2013, at 7:17 AM, Josh Moore notifications@github.com wrote:

That's a very good question, but one I don't know the answer to (right now). Happy to move this to a ticket if you'd rather handle it there. Alternatively, I can try to run again, and provide you a stack trace.

—
Reply to this email directly or view it on GitHub.

[joshmoore]

Otherwise, these compile fine. I'll have to leave the "all tests passing on all machines" for another hudson/jenkins session. Merging.