Simple group view of 'All Members' data. See #10243

[will-moore]

Simply use -1 as a user_id flag to indicate that we don't want to filter by exp_id

[pwalczysko]

Bugs:

1. No right-click menu available on items not owned (already discussed and probably immediately fixed)
2. Right-click and left-click are not in sync on non-owned items (as discussed, very probably fixed together with bug nr. 1).
   • log in as user-3
   • group read-annotate-1, choose "All members"
   • go to item not owned (with the lock sign), right-click on it (it will get grey focus and blue highlight)
   • go to another item and left-click on it - the focus is on the new, left-clicked item (grey) but the blue highlight is still on the previously right-clicked item
     
   • as discussed, this might be browser specific (I am using Safari Mac OS 10.8) - will double check later other browsers
3. This bug was discussed as well - it is described in ticket #10243 - now repeated with a slight modification.
   • log in as any user
   • go to "All members" view (might be not crucial)
   • create a new Screen
   • copy a plate from anywhere (make sure that you ARE allowed to do it)
   • paste the plate into the newly created Screen (works fine)
   • expand the Screen which you just Pasted the plate into
   • expand the plate - beachball appears, during the wait no items appear in the central pane, also no items from other Screens/Plates?Projects/Datasets
   • refresh using the icon above the left-hand pane (does not help)
   • refresh the browser - solves the problem fully

[pwalczysko]

RFE: At the moment, there is a lock icon on the items which you are not allowed to manipulate.
This should be replaced or supplemented with an icon which highlights clearly whether you are the owner of the item or not.
This is important to keep orientation in "All members" view when logged in as admin/group owner.

[pwalczysko]

BUG: see ticket http://trac.openmicroscopy.org.uk/ome/ticket/10424. (Copy of other's data to your dataset causes stack trace)

[pwalczysko]

Analogical error appears after trying to Remove another user's image from the dataset.

• log in as user-3, group read-only
• go to a dataset belonging to user-6
• right-click on an image > Remove
• stack trace appears

Url: /webclient/action/remove/image-locked/36148/
Resolver404: {'path': u'webclient/action/remove/image-locked/36148/', 'tried': [[], [], [], [, ], [, ], [, ((?i)userdata|public|history|search|help|usertags))/$>], [, ], [, ], [, ], [, ], [, ], [, ], [, ], [, ], [, ], [, [a-zA-Z]+)/)?$>], [, ], [, ], [, ], [, clean)/)?$>], 

[pwalczysko]

BUG: Plate wells do not appear in plates owned by other users.

• log in as user-3, group read-only (group owner, you have Edit permissions on other peoples data)
• go to screen "ttte"
• there are two plates under this screen, belonging to user-2
• click on a plate run in any of those two and try to see wells
• you see just blank white panel (but these wells are viewable in Insight)
  

The above described problem might be specific for plates which are inside screens only.
If a plate of other user is without a screen, the wells appear okay.
See below.

[will-moore]

The 'remove' issue above was also fixed by the http://trac.openmicroscopy.org.uk/ome/ticket/10424 fix (commits above). I'll need to reproduce the plate thumbnails issue on my local server before I can work out what's going on here.

[jburel]

doc ticket created see https://trac.openmicroscopy.org.uk/ome/ticket/10432

[pwalczysko]

BUG: After copy of plates into newly created screens problems in viewing the wells (Safari)

• Login as user-3
• Put "All members" to display
• Create a new screen.
• Copy/Paste somebody else's plate into it (make sure the wells are visible before you do it).
• Refresh (inside OMERO.Web)
• Expand the newly created screen
• Expand the plate you copied into the screen.
• You cannot see the wells now
• You cannot see the wells of any other plate either, whether it is your's or other users plate.
• Refresh the browser
• All is fine

Repeated also in Firefox: see screenshot - NB: the Refresh button in OMERO.Web stays "pressed in"

[pwalczysko]

BUG: Copy other user's datasets does not perform the action

• Login as user-3 (group read-only-1)
• Put "All members" to display
• Go to another user's dataset
• Copy it
• Go to your project
• Right-click and Paste
• The action is not performed, although you are allowed to do it and your permissions are also allowing to do it
• If you do the above with copying and pasting other's Images into your Datasets, it works fine
• If you copy and paste your own dataset into your own project, it works fine
• If you copy and paste your own dataset into another user's Project, it works fine

[pwalczysko]

Went through all the bugs reported above. All fixed, works fine.
One new bug found:
BUG:
Remove after Copy does not work for datasets and plates.

• login as user-3
• group read-only-1
• go to Screen "edited by user-2" (owner of the Screen is user-2)
• there is one plate inside this screen, "plate to copy and remove" (owner of the plate is user-10
• copy the plate
• go to another Screen, "change petr" (owner of the Screen is user-4)
• paste the plate into this "change petr" Screen
• action successful, display of the plate in the destination is okay
• right-click onto the plate you just pasted in, choose Remove
• dialog appears asking "Remove ?." - click Yes
• the action is not performed, the plate is still there
• refresh - use refresh button inside Web client
• the "Removed" plate is still there
• refresh the browser window
• the "Removed" plate is still there
• repeat the whole above described workflow, but with a Project in place of a Screen and with a Dataset in place of a Plate - you will get the same result as for plates => not possible to remove

[pwalczysko]

re-test showed that this bug is present even when working with your own datasets and copying them from and pasting into your own projects - i.e. the workflow in the comment above can be simplified - simply copy and paste your own dataset into your project and immediately try to remove it - the action fails. The same goes for screens/plates.

[pwalczysko]

See also https://trac.openmicroscopy.org.uk/ome/ticket/10486#comment:1
This is probably connected to this PR.

[pwalczysko]

Both above mentioned bugs are fixed. Works fine. Ready to merge.

[jburel]

Merging before permissions testing