Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matlab shape helper functions #797

Merged
merged 17 commits into from Mar 7, 2013
Merged

Matlab shape helper functions #797

merged 17 commits into from Mar 7, 2013

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Mar 1, 2013

This PR creates

  • a series of helper functions to create common Shape objects,
  • a generic setShapeCoordinates() function to set z, c, t,
  • a series of unit tests for each new function.

@jburel
Copy link
Member

jburel commented Mar 4, 2013

@sbesson, @joshmoore : good news Matlab is ready. I should have it installed tomorrow. This also means that we should be able to have jobs running soon. I should know more tomorrow.

@jburel
Copy link
Member

jburel commented Mar 5, 2013

@sbesson: the model specified that z, c, t are non negative int. So it should fail.
Also are you planning to add a function for Line?

@sbesson
Copy link
Member Author

sbesson commented Mar 5, 2013

@jburel: addressed most of your comments.

  • added additional input checks in shape creating functions and implemented corresponding unit tests
  • split unit tests into separate classes for each shape
  • setShapeCoordinates() now allows to pass null to the shape. setShapeCoordinates(shape) sets all Z, C, T dimensions to null by default. Should we use 0 as the default? Or should we rather require, z, c, t to be specified in the input (incl. [])?

@jburel
Copy link
Member

jburel commented Mar 6, 2013

We do not use 0 as the default elsewhere. default should be null

@jburel
Copy link
Member

jburel commented Mar 6, 2013

Nothing specific to matlab code, we may want to avoid width, height, radius of 0.

@jburel
Copy link
Member

jburel commented Mar 6, 2013

Maybe it is already in the pipeline, it might be good to add more tests for shape with negative z, c, or t.

@sbesson
Copy link
Member Author

sbesson commented Mar 6, 2013

@jburel:

  • width, height & radii non-zero checks were already implemented. Added corresponding unit tests.
  • added tests for negative Z, C, T as well as explicit setShapeCoordinates(shape, [], [], [])
  • also added a mask size check size in createMask()

@jburel
Copy link
Member

jburel commented Mar 7, 2013

Ready to go unless you are planning to add more commits to that PR.

@sbesson
Copy link
Member Author

sbesson commented Mar 7, 2013

No additional commit for this PR.

jburel added a commit that referenced this pull request Mar 7, 2013
Matlab shape helper functions
@jburel jburel merged commit 361c42c into ome:dev_4_4 Mar 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants