-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matlab shape helper functions #797
Conversation
@sbesson, @joshmoore : good news Matlab is ready. I should have it installed tomorrow. This also means that we should be able to have jobs running soon. I should know more tomorrow. |
@sbesson: the model specified that |
Modify unit tests to implement setUp() method and test all setShapeCoordinates() signatures on each shape type.
@jburel: addressed most of your comments.
|
We do not use |
Nothing specific to matlab code, we may want to avoid width, height, radius of 0. |
Maybe it is already in the pipeline, it might be good to add more tests for shape with negative z, c, or t. |
|
Ready to go unless you are planning to add more commits to that PR. |
No additional commit for this PR. |
This PR creates