Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection #821

Merged
merged 9 commits into from Apr 22, 2013
Merged

Connection #821

merged 9 commits into from Apr 22, 2013

Conversation

jburel
Copy link
Member

@jburel jburel commented Mar 7, 2013

Fixing some issues linked to https://trac.openmicroscopy.org.uk/ome/ticket/10480

No ready for review yet. Required to close tickets.

@jburel
Copy link
Member Author

jburel commented Mar 11, 2013

I have not been able yet to reproduce the IceConnectionLost exception. It might be good to have the PR in the review loop in the next few days.

@jburel
Copy link
Member Author

jburel commented Apr 16, 2013

This PR has been in the build for the past month.
The only untested part is running a local server and using insight when no network up.

@pwalczysko
Copy link
Member

  • Created a test branch and merged this PR in.
  • Built my local server.
  • Started the server with my internet connection on.
  • Logged into OMERO using Insight (to localhost). Works.
  • Closed Insight. Disconnected from internet.
  • Started Inisght, tried to log into OMERO again (localhost again).
  • Spinning beach ball, nothing happens.
  • Clicked Quit in Insight splashscreen.
  • As advised by @jburel , restarted using bin/omero admin restart (Ice does not like the loss of Internet connection when server is running)
  • Started Inisght. Logged into OMERO (to loacalhost).
  • Works as expected with this build & matching Insight client. (when using 4.4.6 release version of Insight, in the same workflow there is Connection Lost dialog and Insight closes)

Ready to merge.

@joshmoore
Copy link
Member

👍

joshmoore added a commit that referenced this pull request Apr 22, 2013
@joshmoore joshmoore merged commit cf0eda4 into ome:dev_4_4 Apr 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants