Big image birdeyeview #940

jburel · 2013-03-22T15:54:48Z

Fix:

Birds eye position: https://trac.openmicroscopy.org.uk/ome/ticket/10477
Selection while loading: https://trac.openmicroscopy.org.uk/ome/ticket/10572
Mouse wheel: https://trac.openmicroscopy.org.uk/ome/ticket/10575
Selector stuck: https://trac.openmicroscopy.org.uk/ome/ticket/10554
Resolution level: full zoom out https://trac.openmicroscopy.org.uk/ome/ticket/8475
Shut down RE when idle: https://trac.openmicroscopy.org.uk/ome/ticket/10579
- To test open an image, do not interact with viewers, after 5/6 mins check the log. The rendering should be closed. Interact with the viewer, The RE is reloaded.

pwalczysko · 2013-03-25T12:58:06Z

Login to Howe as user-6. Put user-4 on display, group read-only-1, open Trestle.

Wait for 5-6 mins not touching anything - image displays okay much sooner.
After 5-6 mins the "RE shut down" entry in Insight log (see below).
Checked the Blitz log on howe, at the corresponding time there is also a corresponding entry.
Zoomed in one step (the image opens now in maximal zoom-out) - got problems with red square == main viewer match (see below in another comment) and the red square did not grow smaller during this step
Zoomed out one more step - the matching was okay after this step and red square did grow smaller
Zoomed out one more step - the matching was okay, but again, the red square did not grow smaller (no zoom out happened)
Waited for more than 10 mins - no new entry in the insight log appeared, although I was not touching the Insight at all - also in the Blitz log on howe, there were plenty of lines indicating the Rendering engines running. These mentioning of Rendering ceased after a while with the line indicated at the bottom of the document.

Insight log after first opening of the image

2013-03-25 11:39:11,398 INFO  [y.shoola.env.data.login.LoginServiceImpl] (nitializer) Logged onto OMERO at: howe.openmicroscopy.org.uk
User Name: user-6 -- Password: ***

2013-03-25 11:49:09,839 INFO  [opy.shoola.env.rnd.PixelsServicesFactory] (1-thread-1) Rendering Engine shut down: PixelsID 51435

Corresponding times
Blitz log on Howe.

2013-03-25 11:49:09,833 INFO  [        ome.services.util.ServiceHandler] (l.Server-2)  Meth:    interface ome.api.StatefulServiceInterface.close
2013-03-25 11:49:09,833 INFO  [        ome.services.util.ServiceHandler] (l.Server-2)  Args:    ()
2013-03-25 11:49:09,834 INFO  [                 org.perf4j.TimingLogger] (l.Server-2) start[1364212149834] time[0] tag[omero.call.success.ome.services.RenderingBean.close]
2013-03-25 11:49:09,834 INFO  [        ome.services.util.ServiceHandler] (l.Server-2)  Rslt:    null
2013-03-25 11:49:09,834 INFO  [                      omero.cmd.SessionI] (l.Server-2) Unregistered servant:85089e8a-7c08-44e6-9add-8f16f0f4f93a/86:24:41:e4:18312f61:13d9ffce6c2:-7ff6omero.api.RenderingEngine(omero.api._RenderingEngineTie@101d81e2)
2013-03-25 11:49:09,836 INFO  [        ome.services.util.ServiceHandler] (l.Server-1)  Meth:    interface ome.api.StatefulServiceInterface.close
2013-03-25 11:49:09,836 INFO  [        ome.services.util.ServiceHandler] (l.Server-1)  Args:    ()
2013-03-25 11:49:09,836 INFO  [                 org.perf4j.TimingLogger] (l.Server-1) start[1364212149836] time[0] tag[omero.call.success.ome.services.RenderingBean.close]
2013-03-25 11:49:09,836 INFO  [        ome.services.util.ServiceHandler] (l.Server-1)  Rslt:    null
2013-03-25 11:49:09,837 INFO  [                      omero.cmd.SessionI] (l.Server-1) Unregistered servant:85089e8a-7c08-44e6-9add-8f16f0f4f93a/86:24:41:e4:18312f61:13d9ffce6c2:-7ff5omero.api.RenderingEngine(omero.api._RenderingEngineTie@56665b72)
2013-03-25 11:49:09,838 INFO  [        ome.services.util.ServiceHandler] (l.Server-9)  Meth:    interface ome.api.StatefulServiceInterface.close
2013-03-25 11:49:09,839 INFO  [        ome.services.util.ServiceHandler] (l.Server-9)  Args:    ()
2013-03-25 11:49:09,839 INFO  [                 org.perf4j.TimingLogger] (l.Server-9) start[1364212149839] time[0] tag[omero.call.success.ome.services.RenderingBean.close]
2013-03-25 11:49:09,839 INFO  [        ome.services.util.ServiceHandler] (l.Server-9)  Rslt:    null
2013-03-25 11:49:09,839 INFO  [                      omero.cmd.SessionI] (l.Server-9) Unregistered servant:85089e8a-7c08-44e6-9add-8f16f0f4f93a/86:24:41:e4:18312f61:13d9ffce6c2:-7ff4omero.api.RenderingEngine(omero.api._RenderingEngineTie@41e428e0)
2013-03-25 11:49:09,840 INFO  [        ome.services.util.ServiceHandler] (l.Server-5)  Meth:    interface ome.api.StatefulServiceInterface.close
2013-03-25 11:49:09,840 INFO  [        ome.services.util.ServiceHandler] (l.Server-5)  Args:    ()
2013-03-25 11:49:09,841 INFO  [                 org.perf4j.TimingLogger] (l.Server-5) start[1364212149841] time[0] tag[omero.call.success.ome.services.RenderingBean.close]
2013-03-25 11:49:09,841 INFO  [        ome.services.util.ServiceHandler] (l.Server-5)  Rslt:    null
2013-03-25 11:49:09,841 INFO  [                      omero.cmd.SessionI] (l.Server-5) Unregistered servant:85089e8a-7c08-44e6-9add-8f16f0f4f93a/86:24:41:e4:18312f61:13d9ffce6c2:-7ff3omero.api.RenderingEngine(omero.api._RenderingEngineTie@651986df)
2013-03-25 11:49:52,187 INFO  [        ome.services.util.ServiceHandler] (l.Server-7)  Meth:    interface ome.api.StatefulServiceInterface.close
2013-03-25 11:49:52,187 INFO  [        ome.services.util.ServiceHandler] (l.Server-7)  Args:    ()
2013-03-25 11:49:52,196 INFO  [         ome.security.basic.EventHandler] (l.Server-7)  Auth:    user=7,group=8,event=null(User),sess=85089e8a-7c08-44e6-9add-8f16f0f4f93a
2013-03-25 11:49:52,198 INFO  [                 org.perf4j.TimingLogger] (l.Server-7) start[1364212192188] time[10] tag[omero.call.success.ome.services.ThumbnailBean.close]
2013-03-25 11:49:52,198 INFO  [        ome.services.util.ServiceHandler] (l.Server-7)  Rslt:    null

Blitz log on Howe after second wait after zooming in couple of times - last mention of "Rendering":



2013-03-25 11:52:48,745 INFO  [                 org.perf4j.TimingLogger] (l.Server-1) start[1364212368666] time[79] tag[omero.call.success.ome.services.RenderingBean.renderCompressed]

pwalczysko · 2013-03-25T13:25:21Z

After some more searching and help from @joshmoore, I guess that there was only one single instance of closing those 4 rendering engines, because running

hudson@howe:~/OMERO-CURRENT/var/log$ grep RenderingBean.close Blitz-0.log |  less

Delivers only this


2013-03-25 11:49:09,834 INFO  [                 org.perf4j.TimingLogger] (l.Server-2) start[1364212149834] time[0] tag[omero.call.success.ome.services.RenderingBean.close]
2013-03-25 11:49:09,836 INFO  [                 org.perf4j.TimingLogger] (l.Server-1) start[1364212149836] time[0] tag[omero.call.success.ome.services.RenderingBean.close]
2013-03-25 11:49:09,839 INFO  [                 org.perf4j.TimingLogger] (l.Server-9) start[1364212149839] time[0] tag[omero.call.success.ome.services.RenderingBean.close]
2013-03-25 11:49:09,841 INFO  [                 org.perf4j.TimingLogger] (l.Server-5) start[1364212149841] time[0] tag[omero.call.success.ome.services.RenderingBean.close]
(END)

This means:

open Trestle and wait for 6 mins
Rendering engine shuts down
zoom in and out, etc.
wait for more than 10 mins after this doing nothing
Rendering engine does not shut down

pwalczysko · 2013-03-25T14:09:56Z

After discussion with @jburel : the mismatch happens only in following workflow:

open the Trestle image and not touching it further, wait for 5 -6 minutes
click to zoom in one single step - a mismatch happens (see screenshot)
if you do not wait for 5-6 minutes, but click to zoom in immediately - all works fine

pwalczysko · 2013-03-25T14:14:36Z

During following workflow, probably due to rounding error, the red square "wanders" to the left:

open Trestle
1. stepwise zoom fully in (0.0645x, 0.125x,.... 1.0x zoom)
1. stepwise zoom fully out (back to 0.03125x)
  The red square is now more to the left than it was before you started zooming in. (see screenshots).

Before

After

jburel · 2013-03-25T21:36:03Z

@pwalczysko: Fix the timeout issue. The problem is not specific to big image.
To test it

open an image, wait 5/6 minutes. until you see an entry like
[opy.shoola.env.rnd.PixelsServicesFactory] (1-thread-1) Rendering Engine shut down: PixelsID 503 in the insight log.
Turn channel off. The Rendering engine(s) should be reloaded. Make sure the channel is turned off, and the image updated.

jburel · 2013-03-25T21:44:02Z

@pwalczysko: I will fix the shift issue in another PR see https://trac.openmicroscopy.org.uk/ome/ticket/10595

will-moore · 2013-03-26T16:29:05Z

The image viewer should not be made smaller for smaller 'Big Images'. We should simply zoom out just enough to see the whole image and no further. E.g. 4K x 4K image opens in a very small window:

pwalczysko · 2013-03-26T16:59:33Z

Opened an image.
Waited 5/6 mins.
Insight log produced a line about RE shut down (see below)

2013-03-26 16:36:46,664 INFO  [opy.shoola.env.rnd.PixelsServicesFactory] (1-thread-1) Rendering Engine shut down: PixelsID 53540

Switched blue channel off
The blue channel button is pressed OUT, but the blue color in the image is still visible
Waited for 6 mins not touching anything
A new line about the RE shut down came to log (as above)
Nothing changed with the image though - still all blue colors visible, the blue channel button pressed OUT
Pressed once more the blue channel button (the button is pressed IN) - the blue colours are visible as before, the button is clearly IN

jburel · 2013-03-26T21:41:18Z

@pwalczysko: the first commit should fix the issue.
@will-moore: resolution level is now determined using the screen size. for the gatan file, using my laptop result is x.25

jburel · 2013-03-27T09:51:54Z

@gusferguson: The last commit addresses your concern about the resolution level cf testing report

pwalczysko · 2013-03-27T11:54:40Z

A. Test the RE shutdown and startup:

The same workflow as yesterday (see the 4th comment in upward direction from this one).

After open/first 6 mins wait - a line appeared in the log:

2013-03-27 10:41:23,369 INFO  [opy.shoola.env.rnd.PixelsServicesFactory] (1-thread-1) Rendering Engine shut down: PixelsID 53540

Switched off the blue channel - works
Switched the blue channel immediately on again - works
Waited another 6 mins doing nothing - a new line appeared in the log:

2013-03-27 10:59:23,496 INFO  [opy.shoola.env.rnd.PixelsServicesFactory] (1-thread-1) Rendering Engine shut down: PixelsID 53540

Switched off the blue channel - works
Switched off the red channel - works
Switched both channels on again - works

This part of the PR works as expected.

B. Test the new display of the big images after opening in full viewer (see examples below):

Now the display after opening is more natural - works fine. Ready to merge.

Big image birdeyeview

jburel added 17 commits March 22, 2013 15:19

Fix scrolling issue when zooming in/out (see #10477)

576846d

Change message to Loading tiles.

99d9ebe

Add/remove listeners depending on state (see #10572)

51acb34

Do not allow panning when loading tiles (see #10572)

e579c2e

Zoom in/out using mouse wheel (see #10575)

0e0d927

Improve painting of tiles. Better feedback.

93ddc75

Remove ref to unused fields.

393e1fa

Fix dragging of selected (see #10554)

733adf5

Review zooming action for big images.

15c0226

Remove cpmputedSize field.

f8f7e47

Modify code to set the preferred resolution level (see #8475)

9b5fead

Fix init sequence when rnd is loaded

8c4ad79

Clean code.

606d04b

Shut down rendering engine if inactive (see #10579)

f3e18eb

Clean and fix log message.

745c33b

Roll back change, specifying security context.

165a676

Add support for long. missing class.

f51cc12

Review reloading sequence of RE after timeout.

dca61e3

jburel mentioned this pull request Mar 26, 2013

Big image rnd (rebased onto develop) #938

Merged

jburel added 2 commits March 26, 2013 21:16

Review reloading.

81424d3

Determine the resolution level depending on screen size.

46b4eba

joshmoore added a commit that referenced this pull request Mar 27, 2013

Merge pull request #940 from jburel/big-image-birdeyeview

0cdfc8a

Big image birdeyeview

joshmoore merged commit 0cdfc8a into ome:dev_4_4 Mar 27, 2013

jburel mentioned this pull request Mar 27, 2013

Big image birdeyeview (rebased onto develop) #962

Merged

will-moore mentioned this pull request Apr 2, 2013

Big image zoom init 8475 #980

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Big image birdeyeview #940

Big image birdeyeview #940

jburel commented Mar 22, 2013

pwalczysko commented Mar 25, 2013

pwalczysko commented Mar 25, 2013

pwalczysko commented Mar 25, 2013

pwalczysko commented Mar 25, 2013

jburel commented Mar 25, 2013

jburel commented Mar 25, 2013

will-moore commented Mar 26, 2013

pwalczysko commented Mar 26, 2013

jburel commented Mar 26, 2013

jburel commented Mar 27, 2013

pwalczysko commented Mar 27, 2013

Big image birdeyeview #940

Big image birdeyeview #940

Conversation

jburel commented Mar 22, 2013

pwalczysko commented Mar 25, 2013

pwalczysko commented Mar 25, 2013

pwalczysko commented Mar 25, 2013

pwalczysko commented Mar 25, 2013

jburel commented Mar 25, 2013

jburel commented Mar 25, 2013

will-moore commented Mar 26, 2013

pwalczysko commented Mar 26, 2013

jburel commented Mar 26, 2013

jburel commented Mar 27, 2013

pwalczysko commented Mar 27, 2013