.travis.yml (take 2) and test fixes #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either due to the recent specification cleanup or due to changes on travis-ci.org itself, the build is now passing.
Previous build with multiple TESTBUILD files failed with out of space and other errors. Until the build can be sped up and simplified, a simple compile test (and for Python, unit tests) probably suffices.
The move to argparse made many of the clitests unnecessary since we no longer have our own `Arguments` class, or use the `_likes()` method.
The ctx field for plugins was making undue use of the OMERODIR global variable. These have been replaced by a call to `_cwd(None)` which internally uses `self.dir` which is usually initialized with `OMERODIR`. This makes it possible to "re-home" a test. With this change and the minor fixes to clitest/db.py all of db.py is now passing.
Not using unittest.main() was causing sys.exit not to be properly called on failures. Now a helper method is available in xmlrunner.main to "do the right thing".
|
Looks great! One hardcoded line used to define |
|
For reference, |
This was referenced Mar 25, 2013
|
Added two minor commits, neither of which will have much code impact. Stylistic comments on ``README.md welcome. /cc @hflynn |
|
What is this docs/QUICKSTART.txt of which you speak? |
|
Actually, can we use Markdown relative path links there? |
|
Ah, I see - yet another place you are hiding documentation! That should probably explain where the full docs are, but yes, not an issue for this PR. |
|
@jburel: nothing more from me if you're ok with merging. |
jburel
added a commit
that referenced
this pull request
Mar 26, 2013
.travis.yml (take 2) and test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for activating Python tests within .travis.yml. Primarily tests have been removed or fixed, though the use of OMERODIR in
src/omero/cli.pywas required for some tests. All tests pass locally, though some are still failing on travis. Opening PR to prevent conflicts in the test classes in other PRs.