Skip to content
This repository has been archived by the owner on Dec 5, 2017. It is now read-only.

Override sphinxdoc.css to put sidebar on the left #11

Merged
merged 1 commit into from
Jul 4, 2014

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jul 3, 2014

Following @pwalczysko suggestions, this PR modifies the generic sphinx_theme
to move the sidebar on the left-side of the window.

Following @pwalczysko suggestions, this PR modifies the generic sphinx_theme
to move the sidebar on the left-side of the window.
@hflynn
Copy link
Member

hflynn commented Jul 3, 2014

Handily, this will cover the BF docs too, won't it? Looks good on omero5-staging 👍

@sbesson
Copy link
Member Author

sbesson commented Jul 3, 2014

Yes any built Sphinx documentation using this theme (i.e. all our deployed HTML documentation) should be modified by this).

@hflynn
Copy link
Member

hflynn commented Jul 4, 2014

Checked on all the staging pages and looks good to me. Happy to merge once @pwalczysko confirms he's happy too.

@pwalczysko
Copy link
Member

Very happy with this. Ta

hflynn added a commit that referenced this pull request Jul 4, 2014
Override sphinxdoc.css to put sidebar on the left
@hflynn hflynn merged commit 6a369a3 into ome:master Jul 4, 2014
@manics
Copy link
Member

manics commented Jul 4, 2014

On a narrower screen:
screen shot 2014-07-04 at 11 23 36

@hflynn
Copy link
Member

hflynn commented Jul 4, 2014

Damn! I'd noticed there wasn't a line dividing the content any more but not that it had consequences for narrower screens. I'll leave @sbesson to play with the settings in a new PR next week. Unless you want to try @manics ?

@hflynn
Copy link
Member

hflynn commented Jul 4, 2014

Actually, I think this may be an issue with the breadcrumbs at the top - the sidebar is being offset rather than being underneath the additional sub-section. We may need to turn them off unless there is a way to make only show 2 levels of hierarchy.

@sbesson sbesson deleted the sidebar_position branch July 7, 2014 09:09
@sbesson
Copy link
Member Author

sbesson commented Jul 9, 2014

I can reproduce the issue indeed but I am having trouble identifying and fixing what is wrong. At this point, I would rather defer to someone with a deeper knowledge of CSS than myself to try and fix this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants