-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
/cc @mtbc, @pwalczysko, @hflynn, @rleigh-dundee, @gusferguson This change will need a consensus between all involved and with an opinion. I see a few solutions here, that will help us avoid spending ages on a convoluted CSS file:
I'm happy with any option. |
Floating seemed good to me, to be honest, but let's see how this looks. |
My 2p about @bpindelski's comment:
|
@sbesson I can open a PR that changes the headings to shorter words. In such a case, do we want to revert to a floating layout? |
To support Blazej's proposal, below are screeshots of three typical pages from our documentation:
Also /cc'ing @qidane who was involved in the desgin of the CSS theme. |
Hard to tell from the screenshots alone since it doesn't show what happens when you make the window smaller (e.g. reduce width by 50%). I'd suggest that 300px hardcoding is bad; on high dpi displays that's less than 1 inch, so could be <10 characters wide. Some tablets are now >350dpi, so pixels as a length specifier are not portable. |
@rleigh-dundee, @sbesson, @pwalczysko - as a compromise I've created a branch (https://github.com/bpindelski/sphinx_theme/tree/overflow2), where the layout is floating, but the "Note" and "Warning" boxes don't escape the flow of the text. See below screenshot: |
Option 3, with the compromise solution as described above in #13 (comment) seems like the best option to me. |
@manics and @joshmoore complained that the sidebar is too wide, so I'll now push the changes from https://github.com/bpindelski/sphinx_theme/tree/overflow2 to this PR. |
A general comment: The font-size of the sidebar text looks to be larger than that of the main docs, and with it's new position on the left I think it's too prominent. One option would be to reduce the font-size, which might also help with some of the width/formatting issues. |
@manics I will not be changing anything but the layout of elements in this PR, sorry. Lets finish this first and then we can have subsequent PRs with other modifications. I any other case this will grow exponentially, as everyone will have a comment. |
If changing font sizes be careful how you do it. If set to a fixed size it will mess up the layout for people like me who have their browser set to use larger fonts. A relative size change would work better. |
@sbesson I've done |
See https://www.openmicroscopy.org/site/support/omero5-staging/index.html for the live deployment of 3fbe331 |
Looks much better, thanks. |
Thanks, @rleigh-dundee @pwalczysko thoughts? |
Assuming the last layout satisfied most of the people, merging this PR. New features/improvements can be carried out in separate ones. Thanks @bpindelski and all for the feedback. |
Change the width of the sidebar.
Chrome/Mac shows weird behavior for https://www.openmicroscopy.org/site/support/omero5-staging/sysadmins/unix/server-postgresql.html: |
@joshmoore, @sbesson See #15. |
This should help avoid situations where the sidebar overflows above the main text: